Migrate older Xcode projects off the legacy build system #52288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
added
tool
christopherfujino
approved these changes
Mar 10, 2020
Contributor
christopherfujino
left a comment
christopherfujino
left a comment
There was a problem hiding this comment.
LGTM with a nit.
| import '../../project.dart'; | ||
| import 'ios_migrator.dart'; | ||
|
|
||
| /// Xcode legacy build system no longer supported by Xcode. |
Contributor
There was a problem hiding this comment.
nit. this seems like it should be a regular comment, and not dartdoc
Member
Author
|
Landing on red to poke Cirrus |
Closed
This was referenced May 8, 2020
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Legacy build system was introduced to work around #20685 (comment). Legacy build system is now causing linker issues with plugins. Remove the build system if they still have the default workspace settings. Ignore the file if it's not quite the same because they already followed the manual migration instructions.
Related Issues
Legacy build system introduced in #21901
Reverted in #33684
Fixes #51992.
Manually fixed in flutter/plugins#2592 firebase/flutterfire#2152
Tests
Added XcodeBuildSystemMigration tests.
Checked out plugin examples before they were manually fixed, confirmed with this change the workspace settings file were deleted.
Checklist
///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change