Skip to content

Step 2: SnackBarBehavior.floating offset fix by default #52136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
shihaohong wants to merge 3 commits into from
Closed

Step 2: SnackBarBehavior.floating offset fix by default #52136

shihaohong wants to merge 3 commits into from

Conversation

@shihaohong
Copy link
Contributor

@shihaohong shihaohong commented Mar 6, 2020

Description

Continuation from #50597, applying the offset fix by default.

Migration guide

  1. Set all instances of Scaffold.shouldSnackBarIgnoreFABRect to true after this PR is merged.
  2. Fix all failing tests. There are likely two main types:
    a) Fix all golden tests to expect the new change.
    b) Fix any widget tests that expect the SnackBar to appear higher than it should. The difference should simply be the size of the floating action button's rect.
  3. Once Scaffold.shouldSnackBarIgnoreFABRect is set to true by default (in a subsequent PR), remove the parameter from all instances of Scaffold.

Related Issues

Addresses #47202
Addresses #43716

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

@shihaohong shihaohong added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Mar 6, 2020
@shihaohong shihaohong requested a review from HansMuller March 6, 2020 20:53
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Mar 6, 2020

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@shihaohong shihaohong mentioned this pull request Mar 23, 2020
Closed
13 tasks
@shihaohong
Copy link
Contributor Author

shihaohong commented Mar 23, 2020 •
edited
Loading

This is currently still being blocked by fixing internal tests. Since there are a ton of golden tests with the SnackBar, this will likely be a longer migration process and I haven't had the time to go through these updates. I'll close the PR for now since I don't have the bandwidth to tackle that migration. When I do, I'll reopen the PR!

@shihaohong shihaohong closed this Mar 23, 2020
@shihaohong shihaohong reopened this Apr 16, 2020
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Apr 16, 2020

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@shihaohong shihaohong mentioned this pull request Apr 16, 2020
Merged
11 tasks
@shihaohong
Copy link
Contributor Author

shihaohong commented Apr 16, 2020

Closing in favor of #54985 because of CI failure unrelated to PR

@shihaohong shihaohong closed this Apr 16, 2020
@shihaohong shihaohong deleted the snackbar-fix branch May 14, 2020 00:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@HansMuller HansMuller Awaiting requested review from HansMuller

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shihaohong @fluttergithubbot @googlebot