Revert "Fix version command for certain git workflows" #52128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 20bf43b.
fluttergithubbot
added
the
tool
dnfield
approved these changes
Mar 6, 2020
Contributor
dnfield
left a comment
dnfield
left a comment
There was a problem hiding this comment.
LGTM.
I think we're going to have to take some kind of performance hit for this, but we can probably optimize this. For now we can revert and try to figure out a more optimal way to make this correct.
Contributor
Author
|
I don't think we should take a performance hit for everyone for a non-standard workflow |
Contributor
|
Yeah, it might be enough to just run this for |
Contributor
Author
|
The tests passed in https://cirrus-ci.com/build/5163935233998848, but the checks didn't update. Landing |
dnfield
added a commit
to dnfield/flutter
that referenced
this pull request
Mar 6, 2020
…r#52062)" (flutter#52128)" This reverts commit e7d70fb.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #52062
This regressed the performance of all flutter commands, including #52121 and flutter_test_performance