[flutter_tools] refactor GenSnapshot and AotBuilder #52091
Conversation
fluttergithubbot
added
tool
|
Same here: The |
| case TargetPlatform.darwin_x64: | ||
| case TargetPlatform.linux_x64: | ||
| case TargetPlatform.windows_x64: | ||
| case TargetPlatform.fuchsia_arm64: |
There was a problem hiding this comment.
Fuchsia supports AOT, but not via this path. Maybe some more targeted tool exit message for fuchsia would be good.
| status?.cancel(); | ||
| globals.printError(error.toString()); | ||
| return; | ||
| throwToolExit(null); |
There was a problem hiding this comment.
A message here would probably be helpful, even if it was just something like "The AOT build failed".
|
|
||
| final SnapshotType snapshotType = SnapshotType(platform, buildMode); | ||
| final int genSnapshotExitCode = | ||
| await _timedStep('snapshot(CompileTime)', 'aot-snapshot', |
There was a problem hiding this comment.
Is this timing info still captured some other way? Or is this reporting no longer valuable because we expect users to be taking a different path?
There was a problem hiding this comment.
We don't use a _timedStep for the current AOT build.
All of this timing information is captured via PerformanceMeasurement classes. This isn't hooked up to analytics yet, but I could update this PR to do so. This has the benefit of allowing uniform handling of build performance
I could wire this up in this PR or do it separately
There was a problem hiding this comment.
Removing this _timedStep removed the compilation times from the log output reported using the --report-timings flag in Golem benchmarking of Flutter.
The failure was not noticed, because the previous backup code path that was used before the --report-timings flag was introduced started running again.
| bool bitcode = kBitcodeEnabledDefault, | ||
| bool quiet = true, | ||
| Iterable<DarwinArch> iosBuildArchs = defaultIOSArchs, | ||
| }) async { |
There was a problem hiding this comment.
Also TargetPlatform.fuchsia_arm64
There was a problem hiding this comment.
Oops, thanks!
This reverts commit f65421a.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
6 participants
Description
GenSnapshotandAotBuilder.GenSnapshotUpon refactoring test code, discover that the
LocalEngineArtifacts._engineSrcPathandArtifact.snapshotDartare completely unused (might predate gen snapshot?). Remove and refactor.