[gen_l10n] Escape quote characters in ARB files#51952
Merged
Merged
Conversation
HansMuller
reviewed
Mar 4, 2020
HansMuller
approved these changes
Mar 4, 2020
|
|
||
| "singleQuote": "Flutter's amazing!", | ||
| "@singleQuote": { | ||
| "description": "Love Flutter!" |
Contributor
There was a problem hiding this comment.
In most of the rest of this file, the message descriptions briefly describe what we're checking.
Contributor
Author
There was a problem hiding this comment.
Modified it to describe the test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using the l10n tool, the following issue has surfaced:
Arb file:
Generated getter:
This PR introduced proper escaping of quote characters. There was also a small change to the stocks app example to make sure to use
en.arbas the template instead ofen_US.arbRelated Issues
Fixes #51787
Tests
I added the following tests:
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.