Skip to content

Revert "Write FLUTTER_BUILD_MODE when using a local engine" #51943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dnfield merged 1 commit into from
Mar 4, 2020
Merged

Revert "Write FLUTTER_BUILD_MODE when using a local engine" #51943

dnfield merged 1 commit into from
Mar 4, 2020

Conversation

@zanderso
Copy link
Member

@zanderso zanderso commented Mar 4, 2020

Reverts #51687

Reverting for analyzer failures:

Analyzing 3 directories...                                      
  error • Missing type arguments for calling generic function type 'PostExpectation<T> Function<T>(T)' • packages/flutter_tools/test/general.shard/ios/xcodeproj_test.dart:463:7 • implicit_dynamic_invoke
  error • The getter 'engineOutPath' isn't defined for the type 'MockArtifacts' • packages/flutter_tools/test/general.shard/ios/xcodeproj_test.dart:463:26 • undefined_getter
  error • Missing type arguments for calling generic function type 'PostExpectation<T> Function<T>(T)' • packages/flutter_tools/test/general.shard/ios/xcodeproj_test.dart:488:7 • implicit_dynamic_invoke
  error • The getter 'engineOutPath' isn't defined for the type 'MockArtifacts' • packages/flutter_tools/test/general.shard/ios/xcodeproj_test.dart:488:26 • undefined_getter
4 issues found. (ran in 327.3s)

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 4, 2020
@zanderso zanderso requested a review from dnfield March 4, 2020 16:27
@dnfield
Copy link
Contributor

dnfield commented Mar 4, 2020

Weird - how did it pass presubmits? LGTM

dnfield
dnfield approved these changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnfield
Copy link
Contributor

dnfield commented Mar 4, 2020

Landing on red to un-red the tree.

cbracken
cbracken approved these changes Mar 4, 2020
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dnfield dnfield merged commit a5bd678 into master Mar 4, 2020
@dnfield dnfield deleted the revert-51687-local_engine_build_mode branch March 4, 2020 16:56
dnfield added a commit to dnfield/flutter that referenced this pull request Mar 5, 2020
@dnfield
Revert "Revert "Write FLUTTER_BUILD_MODE when using a local engine (f…
9f033fa 
…lutter#51687)" (flutter#51943)"

This reverts commit a5bd678.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cbracken cbracken cbracken approved these changes

+1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zanderso @dnfield @cbracken @googlebot @fluttergithubbot