Skip to content

Add textfield perf test to devicelab #51788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Mar 4, 2020
Merged

Add textfield perf test to devicelab #51788

fluttergithubbot merged 1 commit into from
Mar 4, 2020

Conversation

@liyuqian
Copy link
Contributor

@liyuqian liyuqian commented Mar 2, 2020

A continuation of #46720

@liyuqian liyuqian requested a review from GaryQian March 2, 2020 18:56
@fluttergithubbot fluttergithubbot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Mar 2, 2020
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Mar 2, 2020

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@liyuqian liyuqian added a: text input Entering text in a text field or keyboard related problems perf: speed Performance issues related to (mostly rendering) speed c: performance Relates to speed or footprint issues (see "perf:" labels) and removed cla: yes labels Mar 2, 2020
@liyuqian
Copy link
Contributor Author

liyuqian commented Mar 2, 2020

@GaryQian : I just realized that your perf test isn't actually running in the devicelab yet... When this PR is merged, can you please keep an eye on the devicelab, and set the initial baseline for the benchmarks?

GaryQian
GaryQian approved these changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@GaryQian GaryQian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fluttergithubbot fluttergithubbot merged commit e22ceb0 into flutter:master Mar 4, 2020
@liyuqian
Copy link
Contributor Author

liyuqian commented Mar 5, 2020

Thanks @GaryQian ! Please help set the baseline in https://flutter-dashboard.appspot.com/benchmarks.html when you have some time.

@liyuqian liyuqian mentioned this pull request Mar 16, 2020
Closed
@liyuqian liyuqian deleted the text_perf branch April 7, 2020 18:34
This was referenced Jul 21, 2021
Closed
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@GaryQian GaryQian GaryQian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems c: contributor-productivity Team-specific productivity, code health, technical debt. c: performance Relates to speed or footprint issues (see "perf:" labels) perf: speed Performance issues related to (mostly rendering) speed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@liyuqian @fluttergithubbot @GaryQian @googlebot