Skip to content

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented Feb 29, 2020

Description

Today, the flutter build mode is driven by the $CONFIGURATION from Xcode. This is easy to mess up if you're using a local engine, and the error message in such a case isn't helpful.

This change writes the FLUTTER_BUILD_MODE flag for the engine you're using. We can't use the ambient build mode because it doesn't necessarily correspond to the engine build type.

Related Issues

Fixes #51673

Tests

I added the following tests:

Test that we write the right flags into Generated.xcconfig and the other new file.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.

@dnfield dnfield force-pushed the local_engine_build_mode branch from 9d22d4d to 221f8f1 Compare February 29, 2020 05:37
@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 29, 2020
@dnfield dnfield requested a review from jmagman February 29, 2020 05:37
Copy link
Member

@chinmaygarde chinmaygarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dnfield dnfield merged commit 9b4b7d7 into flutter:master Mar 4, 2020
@dnfield dnfield deleted the local_engine_build_mode branch March 4, 2020 15:37
zanderso added a commit that referenced this pull request Mar 4, 2020
dnfield pushed a commit that referenced this pull request Mar 4, 2020
dnfield added a commit to dnfield/flutter that referenced this pull request Mar 5, 2020
@dnfield dnfield mentioned this pull request Mar 5, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document how to run profile/release from Xcode

4 participants