Skip to content

Conversation

@cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented Feb 28, 2020

Description

Regression caused by flutter/engine#16782 and google/skia@b5d977f
The Skia PR fixes #49492 which made the Title text on iOS better.
We should update the golden to accommodate that.

We also want to update the image compare logic to use Skia Gold when it is enabled on flutter driver test: #49815

Temporarily skip the test as it was marked flaky (so no tree blocking if the test fails) anyway. I will enable the test as soon as the Gold api fixes land.

Related Issues

Tests

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

@fluttergithubbot fluttergithubbot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Feb 28, 2020
@cyanglaz cyanglaz requested a review from blasten February 28, 2020 22:06

tearDownAll(() => driver.close());

//TODO(cyanglaz): Enable the test after https://github.com/flutter/flutter/pull/49815 lands.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trivial nit: // TODO

Copy link

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyanglaz cyanglaz merged commit 1d3fcfd into flutter:master Feb 29, 2020
@cyanglaz cyanglaz deleted the screenshot_test branch February 29, 2020 18:01
cbracken added a commit to cbracken/flutter that referenced this pull request Mar 2, 2020
…ter#51665)"

The original commit actually *enabled* the test by removing the
flaky: true field in the commit.

This reverts commit 1d3fcfd.
cbracken added a commit that referenced this pull request Mar 2, 2020
…)" (#51783)

The original commit actually *enabled* the test by removing the
flaky: true field in the commit.

This reverts commit 1d3fcfd.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IOS 13.3 TextStyle FontWeight being completely Ignored

4 participants