Always select a diagonal for ArcTween even if begin and end rects are… #5151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Can we inline maxBy? We want to remove our dependency on this package if possible.
Member
Author
There was a problem hiding this comment.
Moved this into foundation/basic_types
| maxSupport = support; | ||
| } | ||
| } | ||
| _diagonal = maxBy(_allDiagonals, (_Diagonal d) => _diagonalSupport(centersVector, d)); |
Contributor
|
LGTM |
aam
added a commit
to aam/flutter
that referenced
this pull request
May 3, 2018
Changes since last roll: ``` ae0d3a5 Roll dart to 2765fcf2aecd3841d082fedaeafc00a73a965f8c. (flutter#5160) 73b835c Roll src/third_party/skia/ 0caef298c..20fa1e94a (1 commit) (flutter#5159) f5c7cb3 Roll dart to b298fc6d8f6a0e1aa841dbbdda26663d6012a79a. (flutter#5155) 93b85ee Add Android accessibility bridge support for "longPress" and "tap" semantic events 862d13c Roll src/third_party/skia/ 97b48a9c7..0caef298c (6 commits) (flutter#5158) 9b7cc44 Dart bindings own the FDIO namespace. Release the engine side reference to the handle after bindings are setup. (flutter#5156) 8896bd3 Roll src/third_party/skia/ f9ab22385..97b48a9c7 (11 commits; 1 trivial rolls) (flutter#5154) 77910ba Roll src/third_party/skia/ 2050565fe..f9ab22385 (11 commits) (flutter#5151) 0667cba Roll src/third_party/skia/ 3fef39d94..2050565fe (2 commits) (flutter#5150) 5da1716 Roll src/third_party/skia/ ef4142a9b..3fef39d94 (1 commit) (flutter#5148) 4ec4b38 Roll src/third_party/skia/ c86c5c014..ef4142a9b (2 commits) (flutter#5147) d5c1117 Roll dart to 011676641a8b4b77bb372384c712709cbf037675 (flutter#5146) beb988c Roll src/third_party/skia/ 91368c9b9..c86c5c014 (4 commits) (flutter#5145) a58eabf Roll src/third_party/skia/ dc3192b30..91368c9b9 (12 commits; 1 trivial rolls) (flutter#5144) ```
aam
added a commit
that referenced
this pull request
May 3, 2018
…7240) Changes since last roll: ``` ae0d3a5 Roll dart to 2765fcf2aecd3841d082fedaeafc00a73a965f8c. (#5160) 73b835c Roll src/third_party/skia/ 0caef298c..20fa1e94a (1 commit) (#5159) f5c7cb3 Roll dart to b298fc6d8f6a0e1aa841dbbdda26663d6012a79a. (#5155) 93b85ee Add Android accessibility bridge support for "longPress" and "tap" semantic events 862d13c Roll src/third_party/skia/ 97b48a9c7..0caef298c (6 commits) (#5158) 9b7cc44 Dart bindings own the FDIO namespace. Release the engine side reference to the handle after bindings are setup. (#5156) 8896bd3 Roll src/third_party/skia/ f9ab22385..97b48a9c7 (11 commits; 1 trivial rolls) (#5154) 77910ba Roll src/third_party/skia/ 2050565fe..f9ab22385 (11 commits) (#5151) 0667cba Roll src/third_party/skia/ 3fef39d94..2050565fe (2 commits) (#5150) 5da1716 Roll src/third_party/skia/ ef4142a9b..3fef39d94 (1 commit) (#5148) 4ec4b38 Roll src/third_party/skia/ c86c5c014..ef4142a9b (2 commits) (#5147) d5c1117 Roll dart to 011676641a8b4b77bb372384c712709cbf037675 (#5146) beb988c Roll src/third_party/skia/ 91368c9b9..c86c5c014 (4 commits) (#5145) a58eabf Roll src/third_party/skia/ dc3192b30..91368c9b9 (12 commits; 1 trivial rolls) (#5144) ```
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
…utter#17240) Changes since last roll: ``` ae0d3a5 Roll dart to 2765fcf2aecd3841d082fedaeafc00a73a965f8c. (flutter#5160) 73b835c Roll src/third_party/skia/ 0caef298c..20fa1e94a (1 commit) (flutter#5159) f5c7cb3 Roll dart to b298fc6d8f6a0e1aa841dbbdda26663d6012a79a. (flutter#5155) 93b85ee Add Android accessibility bridge support for "longPress" and "tap" semantic events 862d13c Roll src/third_party/skia/ 97b48a9c7..0caef298c (6 commits) (flutter#5158) 9b7cc44 Dart bindings own the FDIO namespace. Release the engine side reference to the handle after bindings are setup. (flutter#5156) 8896bd3 Roll src/third_party/skia/ f9ab22385..97b48a9c7 (11 commits; 1 trivial rolls) (flutter#5154) 77910ba Roll src/third_party/skia/ 2050565fe..f9ab22385 (11 commits) (flutter#5151) 0667cba Roll src/third_party/skia/ 3fef39d94..2050565fe (2 commits) (flutter#5150) 5da1716 Roll src/third_party/skia/ ef4142a9b..3fef39d94 (1 commit) (flutter#5148) 4ec4b38 Roll src/third_party/skia/ c86c5c014..ef4142a9b (2 commits) (flutter#5147) d5c1117 Roll dart to 011676641a8b4b77bb372384c712709cbf037675 (flutter#5146) beb988c Roll src/third_party/skia/ 91368c9b9..c86c5c014 (4 commits) (flutter#5145) a58eabf Roll src/third_party/skia/ dc3192b30..91368c9b9 (12 commits; 1 trivial rolls) (flutter#5144) ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… equal
Fixes #5086