Fix expression evaluation test leaking flutter_tester processes. #51496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let flutter_tester process complete, wait for it completion, kill the test only if didn't complete on time.
fluttergithubbot
added
the
tool
dnfield
approved these changes
Feb 26, 2020
Contributor
dnfield
left a comment
dnfield
left a comment
There was a problem hiding this comment.
nice! LGTM, looks like there's some analysis issue though.
Contributor
|
This fix definitely helped things, but we're still trying to clean up the temp directories before processes have let go of the handles to them. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let flutter_tester process complete, wait for it completion, kill the test only if didn't complete on time.
Fixes #51421