Skip to content

[flutter_tools] remove globals from plist parser and update tests #51444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonahwilliams merged 5 commits into from
Feb 27, 2020
Merged

[flutter_tools] remove globals from plist parser and update tests #51444

jonahwilliams merged 5 commits into from
Feb 27, 2020

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Feb 26, 2020

Description

Towards simpler tool testing

@fluttergithubbot fluttergithubbot added tool Affects the "flutter" command-line tool. See also t: labels. work in progress; do not review labels Feb 26, 2020
@jonahwilliams jonahwilliams marked this pull request as ready for review February 26, 2020 01:31
jmagman
jmagman approved these changes Feb 26, 2020
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

packages/flutter_tools/lib/src/globals.dart

/// The global Stdio wrapper.
Stdio get stdio => context.get<Stdio>() ?? const Stdio();

Copy link
Member

@jmagman jmagman Feb 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra newline

Copy link
Contributor Author

@jonahwilliams jonahwilliams Feb 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@jonahwilliams jonahwilliams merged commit 80619f1 into flutter:master Feb 27, 2020
@jonahwilliams jonahwilliams deleted the more_Test_cleanups_1234 branch February 27, 2020 02:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jmagman jmagman jmagman approved these changes

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jonahwilliams @jmagman @googlebot @fluttergithubbot