Weaken stack-trace based tests to allow auto-roll of new engine which will change the format #51047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… will change the format Follow-up PR will restore those tests with new expectations: flutter#50760
fluttergithubbot
added
the
framework
Contributor
|
Going to land this on red to help us out later today when the engine starts rolling aagian. The build is going to stay red until we manually roll the engine anyway. |
mkustermann
pushed a commit
that referenced
this pull request
Feb 21, 2020
With --lazy-async-stacks the stack output has changed slightly so updating the expect files to match. This is a follow-up to #51047 as a preparation for the next engine roll which will start enabling --lazy-async-stacks in JIT mode.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up PR will restore those tests with new expectations:
#50760