Skip to content

[web] Smoke tests for web engine #51003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nturgut merged 12 commits into from
Feb 24, 2020
Merged

[web] Smoke tests for web engine #51003

nturgut merged 12 commits into from
Feb 24, 2020

Conversation

@nturgut
Copy link
Contributor

@nturgut nturgut commented Feb 19, 2020 •
edited
Loading

Description

We would like to add a simple smoke test which uses Flutter web engine and a Flutter app.

Steps before merging the PR:

Then we can add a task that looks like this to Cirrus:

dart dev/webdriver_test.dart &
flutter drive --target=test_driver/scroll_perf_web.dart -d web-server --release --browser-name=chrome

Related Issues

Tests

This PR only includes only test code.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

@nturgut nturgut requested a review from yjbanov February 19, 2020 00:13
@fluttergithubbot fluttergithubbot added d: examples Sample code and demos c: contributor-productivity Team-specific productivity, code health, technical debt. labels Feb 19, 2020
yjbanov
yjbanov reviewed Feb 19, 2020
View reviewed changes
@nturgut nturgut mentioned this pull request Feb 20, 2020
Merged
13 tasks
@nturgut nturgut added the waiting for PR to land (fixed) A fix is in flight label Feb 20, 2020
@nturgut
Copy link
Contributor Author

nturgut commented Feb 20, 2020

Waiting for another PR to land before merging this test.

yjbanov
yjbanov approved these changes Feb 20, 2020
View reviewed changes
.cirrus.yml Outdated
Copy link
Contributor

@yjbanov yjbanov Feb 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we reuse the web_integration_tests shard?

Copy link
Contributor Author

@nturgut nturgut Feb 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is very different as the content goes. Especially with the template. May be I am missing something. What is the advantage if we use it? We should also change/remove the template from that shard then.

Copy link
Contributor

@yjbanov yjbanov Feb 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A smoke test is an integration test. It's just a simple integration test. So I thought it belonged in the integration test shard. We also probably don't want too many shards as they all run simultaneously and occupy machines. I imagine eventually we'll have a hundred integration tests, and we'll shard them into N shards as we see fit, similarly to what we do with widget tests. This way we don't have hand-maintained specialized shards.

@nturgut nturgut merged commit 9ba4eb0 into flutter:master Feb 24, 2020
jonahwilliams
jonahwilliams reviewed Feb 24, 2020
View reviewed changes
examples/hello_world/lib/main.dart
import 'package:flutter/widgets.dart';

void main() => runApp(const Center(child: Text('Hello, world!', textDirection: TextDirection.ltr)));
void main() =>
Copy link
Contributor

@jonahwilliams jonahwilliams Feb 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you open a new PR to revert this change?

Copy link
Contributor

@yjbanov yjbanov Feb 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It adds a key to the Text widget, which is needed by the test.

Copy link
Contributor Author

@nturgut nturgut Feb 25, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we reverting the change? The test are passing. I checked the smoke test after the PR went in. It always passed. Build was also green after my change according to the dashboard.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@yjbanov yjbanov yjbanov approved these changes

+1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. d: examples Sample code and demos

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nturgut @yjbanov @jonahwilliams @googlebot @fluttergithubbot