Skip to content

Conversation

@abarth
Copy link
Contributor

@abarth abarth commented Nov 7, 2015

No description provided.

@abarth
Copy link
Contributor Author

abarth commented Nov 7, 2015

@devoncarew

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe note that these are inited on startup from FlutterCommandRunner?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Having these in statics is kind of wonky. I bet there's a better way to do it.

@devoncarew
Copy link
Contributor

lgtm! We'll need to update docs to clarify how users should get getting the flutter repo and setting up env. variables and such.

@abarth
Copy link
Contributor Author

abarth commented Nov 8, 2015

We'll need to update docs to clarify how users should get getting the flutter repo and setting up env. variables and such.

The end-user won't need to set up any env variables. The bin/flutter script sets up everything by looking at its own path in the file system. It actually does all the work of running pub on flutter_tools and compiling the snapshot, etc. Eventually it will also pull down a copy of the Dart SDK so that the "getting started" instructions will just be:

  1. Clone the repo
  2. Run flutter init -o my_project

abarth added a commit that referenced this pull request Nov 8, 2015
Teach flutter init how to depend on flutter using a relative path
@abarth abarth merged commit 9bc6e68 into flutter:master Nov 8, 2015
@abarth abarth deleted the init_from_path branch November 8, 2015 05:36
@Reagankm Reagankm mentioned this pull request Jan 19, 2017
@akashgk akashgk mentioned this pull request Jun 18, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants