Skip to content

Reland test #50987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dnfield merged 3 commits into from
Feb 20, 2020
Merged

Reland test #50987

dnfield merged 3 commits into from
Feb 20, 2020

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented Feb 18, 2020

Relands it as flaky to help with figuring out why it keeps timing out.

@fluttergithubbot fluttergithubbot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Feb 18, 2020
jonahwilliams
jonahwilliams approved these changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnfield dnfield mentioned this pull request Feb 18, 2020
Merged
@dnfield
Copy link
Contributor Author

dnfield commented Feb 18, 2020

@liyuqian - I removed the macos project from this PR and moved that out to #50999

liyuqian
liyuqian approved these changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@liyuqian liyuqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnfield dnfield merged commit d030296 into flutter:master Feb 20, 2020
@jmagman jmagman mentioned this pull request Mar 4, 2020
Merged
10 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@jonahwilliams jonahwilliams jonahwilliams approved these changes

@liyuqian liyuqian liyuqian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dnfield @jonahwilliams @liyuqian @googlebot @fluttergithubbot