Skip to content

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented Feb 14, 2020

Make sure the Fuchsia artifacts are available before rolling.

This can happen if someone manually rolls the engine, or if the roller gets misconfigured to not look for fuchsia.stamp

.cirrus.yml Outdated
only_if: "changesInclude('.cirrus.yml', 'bin/internal/engine.version')"
script:
- flutter precache --fuchsia --no-android --no-ios
- flutter precache --flutter_runner --no-andorid --no-ios
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/andorid/android

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, done

@dnfield
Copy link
Contributor Author

dnfield commented Feb 14, 2020

It looks like this precache doesn't fail - I would have expected it to. What gives?

@xster
Copy link
Member

xster commented Feb 14, 2020

Weird that this test ran on engine c4229bf whereas head engine version is d60f298 which is the one with the missing fuchsia thing

Copy link
Contributor

@iskakaushik iskakaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnfield
Copy link
Contributor Author

dnfield commented Feb 14, 2020

Ok, now it's red as expected.

@dnfield
Copy link
Contributor Author

dnfield commented Feb 14, 2020

Landing on red, to make the tree, because the tree is broken and no one knows right now.

@dnfield dnfield merged commit 63ca334 into flutter:master Feb 14, 2020
@dnfield dnfield deleted the fuchsia_precache branch February 14, 2020 21:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants