Skip to content

Update test expectations after using --lazy-async-stacks in JIT mode #50760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mkustermann wants to merge 1 commit into from
Closed

Update test expectations after using --lazy-async-stacks in JIT mode #50760

mkustermann wants to merge 1 commit into from

Conversation

@mkustermann
Copy link
Member

@mkustermann mkustermann commented Feb 13, 2020

This is the accompanying change for [0]: We should include this change together with the roll.

[0] flutter/engine#16556

@fluttergithubbot fluttergithubbot added the framework flutter/packages/flutter repository. See also f: labels. label Feb 13, 2020
@mkustermann mkustermann mentioned this pull request Feb 13, 2020
Merged
@mkustermann mkustermann requested a review from dnfield February 19, 2020 16:17
@dnfield
Copy link
Contributor

dnfield commented Feb 19, 2020

How about we just temporarily disabled the test until the engine rolls to avoid the need for another manual roll?

@mkustermann
Copy link
Member Author

mkustermann commented Feb 19, 2020

Friendly ping :)

I don't want to land the engine change (see flutter/engine#16556) without having approval for this one first, because it makes sense to land them together.

mkustermann added a commit to mkustermann/flutter that referenced this pull request Feb 19, 2020
@mkustermann
Weaken stack-trace based tests to allow auto-roll of new engine which…
a68ede7 
… will change the format

Follow-up PR will restore those tests with new expectations:
flutter#50760
@mkustermann mkustermann mentioned this pull request Feb 19, 2020
Merged
@mkustermann
Copy link
Member Author

mkustermann commented Feb 19, 2020

How about we just temporarily disabled the test until the engine rolls to avoid the
need for another manual roll?

Great idea: #51047

dnfield pushed a commit that referenced this pull request Feb 19, 2020
@mkustermann
Weaken stack-trace based tests to allow auto-roll of new engine which…
17de0c5 
… will change the format (#51047)

Follow-up PR will restore those tests with new expectations:
#50760
@mkustermann
Update test expectations after using --lazy-async-stacks in JIT mode
16f2a4e 
This is the accompaning change for [0], once that change gets rolled into flutter/flutter

[0] flutter/engine#16556
@mkustermann mkustermann force-pushed the lazy-async-stacks-by-default branch from 44f2797 to 16f2a4e Compare February 20, 2020 17:35
@mkustermann
Copy link
Member Author

mkustermann commented Feb 20, 2020

I've just submitted the engine CL, once that gets rolled into flutter/flutter this PR's presubmit checks should succeed and we can land it.

@Piinks Piinks added the a: tests "flutter test", flutter_test, or one of our tests label Feb 21, 2020
@chunhtai
Copy link
Contributor

chunhtai commented Feb 27, 2020

Can this one be rebased and try to see if it pass?

@chunhtai
Copy link
Contributor

chunhtai commented Mar 3, 2020

a friendly bump

@goderbauer
Copy link
Member

goderbauer commented Mar 11, 2020

@mkustermann Is this one still on your radar?

@goderbauer
Copy link
Member

goderbauer commented Apr 1, 2020

@mkustermann I am going to close this one for now as it is getting pretty old. Please feel free to re-open when you find the time to look at it again. Thanks!

@goderbauer goderbauer closed this Apr 1, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chinmaygarde chinmaygarde Awaiting requested review from chinmaygarde

@jonahwilliams jonahwilliams Awaiting requested review from jonahwilliams

@dnfield dnfield Awaiting requested review from dnfield

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@mkustermann @dnfield @chunhtai @goderbauer @googlebot @Piinks @fluttergithubbot