Skip to content

Use forward slashes on Windows for git exclude #50662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmagman merged 2 commits into from
Feb 13, 2020
Merged

Use forward slashes on Windows for git exclude #50662

jmagman merged 2 commits into from
Feb 13, 2020

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Feb 12, 2020

Description

git clean -xffd --exclude=bin\cache\ wasn't working on Windows:

C:\Windows\Temp\flutter sdk>call git clean -xffd --exclude=bin\cache\ 
Removing bin/cache/

git wants forward slashes for this flag, even on Windows.

Related Issues

Pulled out from #50527

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read [Handling breaking changes].

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

@jmagman jmagman added c: contributor-productivity Team-specific productivity, code health, technical debt. team-infra Owned by Infrastructure team labels Feb 12, 2020
@jmagman jmagman self-assigned this Feb 12, 2020
christopherfujino
christopherfujino approved these changes Feb 12, 2020
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can you add a comment here? cos it looks wrong, I might just change this in some other PR later.

LGTM

@jmagman jmagman merged commit e5de31d into flutter:master Feb 13, 2020
@jmagman jmagman deleted the windows-exclude branch February 13, 2020 00:10
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. team-infra Owned by Infrastructure team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmagman @christopherfujino @googlebot