Skip to content

[flutter_tools] Disable analytics for more bots #50579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Feb 11, 2020
Merged

[flutter_tools] Disable analytics for more bots #50579

fluttergithubbot merged 1 commit into from
Feb 11, 2020

Conversation

@zanderso
Copy link
Member

@zanderso zanderso commented Feb 11, 2020 •
edited
Loading

Description

This PR attempts to teach the BotDetector to recognize when the tool is running in the cloud on Azure. This is accomplished by querying the Azure Instance Metadata Service via the non-routable IP address 169.254.169.254. If we don't get a socket connection to that address within one second, this PR assumes that the tool is not on Azure.

Refactorings to support the bot detector now being async are also included.

Related Issues

#4709

Tests

I added the following tests:

Test in bot_detector_test.dart.

Breaking Change

Did any tests fail when you ran them? Please read [Handling breaking changes].

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

@zanderso zanderso added tool Affects the "flutter" command-line tool. See also t: labels. work in progress; do not review labels Feb 11, 2020
jonahwilliams
jonahwilliams approved these changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tvolkert
tvolkert reviewed Feb 11, 2020
View reviewed changes
packages/flutter_tools/lib/src/base/bot_detector.dart Outdated
Copy link
Contributor

@tvolkert tvolkert Feb 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this public and @visibleForTesting so you can unit test it?

Copy link
Member Author

@zanderso zanderso Feb 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, right. Done.

@fluttergithubbot fluttergithubbot merged commit 0a38f29 into flutter:master Feb 11, 2020
@jmagman jmagman mentioned this pull request Feb 12, 2020
Closed
zanderso added a commit that referenced this pull request Feb 12, 2020
@zanderso
Revert "[flutter_tools] Disable analytics for more bots (#50579)"
7dfdcd5 
This reverts commit 0a38f29.
@zanderso zanderso mentioned this pull request Feb 12, 2020
Merged
zanderso added a commit that referenced this pull request Feb 12, 2020
@zanderso
Revert "[flutter_tools] Disable analytics for more bots (#50579)" (#5…
1903ce0 
…0622)

This reverts commit 0a38f29.
@zanderso zanderso mentioned this pull request Feb 12, 2020
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@jonahwilliams jonahwilliams jonahwilliams approved these changes

@tvolkert tvolkert tvolkert approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zanderso @jonahwilliams @tvolkert @googlebot @fluttergithubbot