Skip to content

Conversation

@christopherfujino
Copy link
Contributor

Description

Currently, this test only runs post-submit for release and hotfix branches. This change will make it run pre & post for any PR that isn't merging into master.

Related Issues

Fixes #50384

Tests

This causes an existing test to run in more situations.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read [Handling breaking changes].

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

@christopherfujino christopherfujino force-pushed the further-codesign-test-improvements branch from 3ad492f to 77493ce Compare February 10, 2020 22:37
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- name: verify_binaries_codesigned-macos # macos-only
# TODO(fujino): remove this `only_if` after https://github.com/flutter/flutter/issues/44372
only_if: "$CIRRUS_BRANCH == 'dev' || $CIRRUS_BRANCH == 'beta' || $CIRRUS_BRANCH == 'stable' || $CIRRUS_BRANCH =~ '.*hotfix.*'"
only_if: "$CIRRUS_BASE_BRANCH != 'master'"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$CIRRUS_BASE_BRANCH - nice.

@christopherfujino christopherfujino merged commit 7b7bd11 into flutter:master Feb 13, 2020
@christopherfujino christopherfujino deleted the further-codesign-test-improvements branch February 13, 2020 01:00
@christopherfujino
Copy link
Contributor Author

This ran on post-submit, not sure why. Until I do, I will revert.

@christopherfujino christopherfujino restored the further-codesign-test-improvements branch February 13, 2020 01:02
christopherfujino added a commit that referenced this pull request Feb 13, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

run flutter precache before verify_binaries_codesigned-macos test

3 participants