Skip to content

Conversation

@christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented Feb 10, 2020

Description

This cherry-picks into stable v1.12.13:

To fix flutter apps not running on pre-4.4 (Lollipop) Android.

Related Issues

Fixes #45732
Fixes #47609
Fixes #47112

Tests

I added the following tests:

This adds two unit tests of the android logreader.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read [Handling breaking changes].

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

@fluttergithubbot
Copy link
Contributor

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to v1.12.13-hotfixes. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master. The circumstances where this is valid are very rare.

/cc @dnfield

@fluttergithubbot fluttergithubbot changed the base branch from v1.12.13-hotfixes to master February 10, 2020 19:33
@fluttergithubbot fluttergithubbot added engine flutter/engine related. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Feb 10, 2020
@christopherfujino christopherfujino changed the base branch from master to v1.12.13-hotfixes February 10, 2020 19:34
@christopherfujino christopherfujino changed the title Do not use logcat -T on pre-lollipop Android Stable hotfix: Do not use logcat -T on pre-lollipop Android Feb 10, 2020
@christopherfujino christopherfujino changed the title Stable hotfix: Do not use logcat -T on pre-lollipop Android v1.12.13+hotfix.8 cherry-picks - Do not use logcat -T on pre-lollipop Android Feb 10, 2020
Copy link

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanderso
Copy link
Member

This missed the crash-fix for #45743 in #50029.

@christopherfujino
Copy link
Contributor Author

This missed the crash-fix for #45743 in #50029.

Shoot, I'll look at that first thing Monday.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. engine flutter/engine related. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flutter version >1.9.1 not working on Android 4.4 and lower Crashing on Android Kitkat (4.4) Some microbenchmarks stopped sending data

6 participants