more gradle upgrades #50388

dnfield · 2020-02-08T00:52:30Z

dnfield · 2020-02-08T00:53:03Z

packages/flutter_tools/templates/plugin/android.tmpl/gradle/wrapper/gradle-wrapper.properties

 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-4.10.2-all.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-5.6.2-all.zip


This is the only one I'm not 100% sure about whether we should touch. This affects customers.

Should we split it to another PR? WDYT @blasten?

this file isn't really used. I don't think it will break customers as far as I can tell.

Actually. This is used if a developer tries to build the plugin alone using Android Studio. cc @gaaclarke who just had this issue. (#50480)

dnfield · 2020-02-08T00:54:09Z

We may also want to use -bin instead of -all, as it would save on some download size on CI. But I'd rather do that in a separate PR and change all of them in one go.

christopherfujino · 2020-02-08T00:59:36Z

gonna wait for the linux tests to pass with the new docker build, but then should approve

blasten · 2020-02-08T01:00:58Z

dev/ci/docker_linux/Dockerfile

 RUN mkdir -p "${GRADLE_ROOT}"
 ENV GRADLE_ARCHIVE="${GRADLE_ROOT}/gradle.zip"
-ENV GRADLE_URL="https://services.gradle.org/distributions/gradle-4.4-bin.zip"
+ENV GRADLE_URL="https://services.gradle.org/distributions/gradle-5.6.2-bin.zip"


what is this used for though? Do we have tests that call the global Gradle instead of the gradlew script?

This is what gradlew will use to download the gradle we actually want.

It would be nice if gradlew was smart enough to realize your system gradle was already the right version, but either way it's easier to just find and replace these if they're all in sync. And the current version definitely has bugs around unicode handling...

gradlew initializes the download of the Gradle binary based on the distributionUrl from gradle-wrapper.properties.

But gradlew uses gradle to do the download :)

IOW, you can't use gradlew if you don't already have gradle installed.

(Which is why it would be nice if gradlew would somehow just check if your current gradle version is the same as what it's about to download)

gradlew is just a script that initializes gradle-wrapper.jar. The only requirement is to have java installed.

Ahh hm. I thought for sure at some point it required gradle of some version to be installed first. I was either wrong or that's changed.

I'm not sure why we need this then.

I'll get rid of it and see what breaks haha

dnfield · 2020-02-08T17:37:42Z

Probably have to sync this to head for the golden failure.

dnfield · 2020-02-08T18:25:00Z

Is there an introaged golden or something?

blasten

LGTM

christopherfujino · 2020-02-10T17:35:58Z

Taking Gradle out of the Dockerfile makes me happy, LGTM.

dnfield · 2020-02-10T17:38:33Z

I was confusing that you need gradle to initialize the gradle wrapper, but once its initialize dyou don't need it anymore - and we just keep the initialized files checked in.

christopherfujino · 2020-02-10T17:39:13Z

I was confusing that you need gradle to initialize the gradle wrapper, but once its initialize dyou don't need it anymore - and we just keep the initialized files checked in.

Ah, that makes sense, since I've never had to install Gradle before Flutter.

dnfield · 2020-02-10T17:48:08Z

@Piinks @yjbanov - do either of you know why the oglden test keeps failing on web for this? These changes can't possibly be impacting it. I've tried triaging the golden a few times, but it seems like no matter what I do it fails again.

Piinks · 2020-02-10T17:53:52Z

Hm. It looks like this changed 5 golden files. According to the dashboard, they have all been triaged as positive. Looks like they are all related to shadows, is this expected to change those files?

dnfield · 2020-02-10T18:01:53Z

No, this is changing gradle wrapper options for Android builds. This should have 0 impact on web, and 0 impact on goldens.

Piinks · 2020-02-10T18:02:08Z

It looks like a different one is failing each time...

dnfield · 2020-02-10T18:02:53Z

My assumption is that something on master has actually changed these and this patch is the first one to catch it, but that may be wrong.

Perhaps I keep facing issues because it's runninginto errors sequentially and failing ont he first one?

dnfield · 2020-02-10T18:03:38Z

I've been approving them because they seem like minor pixel differences.

Piinks · 2020-02-10T18:04:31Z

Now there are 6. For some reason it looks like each re-run has failed a new golden file test. It's only happening on web... maybe @chingjun will have some insight?

dnfield · 2020-02-10T18:08:45Z

Talked offline and we think we figured it out.

This test is updating the docker image, which may be pulling in a newer version of chrome, which means rendering differences on shadows perhaps.

Unfortunately,t he test I'm running runs in a loop and is failing on the first failure and not executing the rest of the tests, so gold is only letting me triage one by one.

Piinks · 2020-02-10T18:09:01Z

Caught up offline, that test runs on a loop through different elevation values. A different one in each run is failing because it is throwing inside of the loop. I'm going to update the test to get it out of a loop.

The cause for the change may be because we are picking up a new version of chrome.

christopherfujino · 2020-02-10T18:10:44Z

Ahh, Chrome update! I guess the web goldens will be susceptible to this every time our Docker image pulls in a new Chrome version.

dnfield · 2020-02-10T18:32:52Z

Ok, with the test rewritten so the loop is outside the test I was able to triage all the shadow changes at once. It should pass now.

christopherfujino

LGTM. Plan to hotfix this into stable.

dnfield · 2020-02-10T22:16:42Z

Tree is not red. Merging this.

more gradle upgrades

6ea3a28

dnfield requested a review from blasten February 8, 2020 00:52

dnfield requested a review from christopherfujino as a code owner February 8, 2020 00:52

fluttergithubbot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Feb 8, 2020

googlebot added the cla: yes label Feb 8, 2020

dnfield commented Feb 8, 2020

View reviewed changes

blasten reviewed Feb 8, 2020

View reviewed changes

jmagman added the t: gradle "flutter build" and "flutter run" on Android label Feb 8, 2020

drop gradle from image

e075ed4

dnfield mentioned this pull request Feb 8, 2020

Hotfix 8 - sign binaries and increase minimum Xcode version to 11 #50291

Merged

13 tasks

Merge remote-tracking branch 'upstream/master' into gradle

dee0c27

blasten approved these changes Feb 9, 2020

View reviewed changes

change loop

552cd49

dnfield mentioned this pull request Feb 10, 2020

Java Plugin template doesn't compile #50480

Closed

dnfield added the waiting for tree to go green label Feb 10, 2020

christopherfujino approved these changes Feb 10, 2020

View reviewed changes

christopherfujino mentioned this pull request Feb 10, 2020

v1.12.13+hotfix.8 cherry-picks - gradle upgrades #50489

Merged

13 tasks

dnfield merged commit ffc8559 into flutter:master Feb 10, 2020

dnfield deleted the gradle branch February 10, 2020 22:16

This was referenced Feb 26, 2020

CI networking issues #50730

Closed

Cirrus network connection failures on flutter/plugins CI #51074

Closed

github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2021

more gradle upgrades #50388

more gradle upgrades #50388

Uh oh!

Conversation

dnfield commented Feb 8, 2020 • edited by blasten Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

blasten Feb 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dnfield commented Feb 8, 2020

Uh oh!

christopherfujino commented Feb 8, 2020

Uh oh!

blasten Feb 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dnfield commented Feb 8, 2020

Uh oh!

dnfield commented Feb 8, 2020

Uh oh!

blasten left a comment

Choose a reason for hiding this comment

Uh oh!

christopherfujino commented Feb 10, 2020

Uh oh!

dnfield commented Feb 10, 2020

Uh oh!

christopherfujino commented Feb 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dnfield commented Feb 10, 2020

Uh oh!

Piinks commented Feb 10, 2020

Uh oh!

dnfield commented Feb 10, 2020

Uh oh!

Piinks commented Feb 10, 2020

Uh oh!

dnfield commented Feb 10, 2020

Uh oh!

dnfield commented Feb 10, 2020

Uh oh!

Piinks commented Feb 10, 2020

Uh oh!

dnfield commented Feb 10, 2020

Uh oh!

Piinks commented Feb 10, 2020

Uh oh!

christopherfujino commented Feb 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dnfield commented Feb 10, 2020

Uh oh!

christopherfujino left a comment

Choose a reason for hiding this comment

dnfield commented Feb 8, 2020 •

edited by blasten

Loading

blasten Feb 10, 2020 •

edited

Loading

blasten Feb 8, 2020 •

edited

Loading

christopherfujino commented Feb 10, 2020 •

edited

Loading

christopherfujino commented Feb 10, 2020 •

edited

Loading