Skip to content

Update minimum version to Xcode 11.0 #50315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmagman merged 1 commit into from
Feb 7, 2020
Merged

Update minimum version to Xcode 11.0 #50315

jmagman merged 1 commit into from
Feb 7, 2020

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Feb 7, 2020 •
edited
Loading

Description

Updated minimum version of Xcode to match LUCI builder. Xcode 11 was released September 2019.

Related Issues

Tool change part of #49787.

Tests

Updated xcodeproj_test and xcode_test.

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

@jmagman jmagman added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. platform-mac Building on or for macOS specifically t: xcode "xcodebuild" on iOS and general Xcode project management labels Feb 7, 2020
@jmagman jmagman requested a review from dnfield February 7, 2020 03:14
@jmagman jmagman self-assigned this Feb 7, 2020
@jmagman jmagman mentioned this pull request Feb 7, 2020
Closed
@jmagman
Copy link
Member Author

jmagman commented Feb 7, 2020 •
edited
Loading

Blocked on devicelab mac-10 upgrading to Xcode 11.
Do not submit this change until it is given approval in #49787.

@jmagman jmagman requested a review from zanderso February 7, 2020 03:17
dnfield
dnfield approved these changes Feb 7, 2020
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Maybe we could avoid some of this fallout in the future by making the devicelab tests enable bitcode?

@jmagman
Copy link
Member Author

jmagman commented Feb 7, 2020

LGTM.

Maybe we could avoid some of this fallout in the future by making the devicelab tests enable bitcode?

It manifests with bitcode disabled, too. Archiving doesn't reproduce it, it needs to be validated.

@dnfield
Copy link
Contributor

dnfield commented Feb 7, 2020

We could add a test that just runs the validate Xcode check against the plist right?

@dnfield
Copy link
Contributor

dnfield commented Feb 7, 2020

And give it a nice clear error message too

@pawlowskim
Copy link

pawlowskim commented Feb 7, 2020

LGTM.
Maybe we could avoid some of this fallout in the future by making the devicelab tests enable bitcode?

It manifests with bitcode disabled, too. Archiving doesn't reproduce it, it needs to be validated.

I can confirm that during export / validation this happens.

** ARCHIVE SUCCEEDED **

+ xcodebuild -exportArchive -archivePath /Volumes/xxx/yyy/workspace/ccc/ios/build/vvv.xcarchive -exportOptionsPlist exportOptions.plist -exportPath /Volumes/xxx/yyy/workspace/ccc/ios/../build/vvv.ipa
2020-01-30 15:29:24.053 xcodebuild[30972:3771336] [MT] IDEDistribution: -[IDEDistributionLogging _createLoggingBundleAtPath:]: Created bundle at path '/var/folders/wt/jjmd1pm16lv1d9ntx203shw00000gp/T/Release-Integration_2020-01-30_15-29-24.047.xcdistributionlogs'.
error: exportArchive: Failed to verify bitcode in Flutter.framework/Flutter:
error: Linker option verification failed for bundle /var/folders/wt/jjmd1pm16lv1d9ntx203shw00000gp/T/FluttermQF29X/Flutter.armv7.xar (unrecognized arguments: -platform_version iOS 8.0.0 13.0.0)

@christopherfujino christopherfujino mentioned this pull request Feb 7, 2020
Merged
13 tasks
@jmagman
Copy link
Member Author

jmagman commented Feb 7, 2020

gauge tests off, merging...

@jmagman jmagman merged commit 2b7582e into flutter:master Feb 7, 2020
@jmagman jmagman deleted the xcode-version branch February 7, 2020 21:57
jmagman added a commit that referenced this pull request Feb 7, 2020
@jmagman
Revert "Update minimum version to Xcode 11.0 (#50315)"
45d34c3 
This reverts commit 2b7582e.
@jmagman jmagman mentioned this pull request Feb 7, 2020
Merged
jmagman added a commit that referenced this pull request Feb 7, 2020
@jmagman
Revert "Update minimum version to Xcode 11.0 (#50315)" (#50369)
48a9bd5 
This reverts commit 2b7582e.
@jmagman
Copy link
Member Author

jmagman commented Feb 7, 2020

I forgot this was blocked on devicelab mac-10 upgrading to Xcode 11 even though I made the note for myself above. Reverted.

@jmagman jmagman restored the xcode-version branch February 7, 2020 22:16
@jmagman jmagman mentioned this pull request Feb 7, 2020
Merged
@christopherfujino christopherfujino mentioned this pull request Feb 11, 2020
Closed
This was referenced Feb 26, 2021
Closed
Merged
@jmagman jmagman mentioned this pull request Mar 3, 2021
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@zanderso zanderso zanderso approved these changes

+1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

platform-ios iOS applications specifically platform-mac Building on or for macOS specifically t: xcode "xcodebuild" on iOS and general Xcode project management tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jmagman @dnfield @pawlowskim @zanderso @googlebot