Hotfix 8 - sign binaries and increase minimum Xcode version to 11 #50291

christopherfujino · 2020-02-06T19:55:27Z

Description

cherry pick:

engine #16344 - trivial update to trigger new build that can be codesigned.
framework #50074 and #50289 - add cirrus integration test to detect unsigned binaries.
framework #50315 - update minimum xcode version to 11

In addition the customer_testing tests initially failed on this PR because the cirrus config checks out ToT of https://github.com/flutter/tests, and upstream changes are incompatible with this version. I updated these tests in the .cirrus.yml to check out the specific revision this repo was on when this release branched from master.

Related Issues

Fixes #50066 and #49787

Tests

I added the following tests:

Cherry picked a cirrus integration test that verifies all binaries in the cache have been codesigned (only runs on macos).

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I signed the [CLA].
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I updated/added relevant documentation (doc comments with ///).
All existing and new tests are passing.
The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read [Handling breaking changes].

No, no existing tests failed, so this is not a breaking change.
Yes, this is a breaking change. If not, delete the remainder of this section.
- I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
- I got input from the developer relations team, specifically from: Replace with the names of who gave advice
- I wrote a migration guide: Replace with a link to your migration guide

fluttergithubbot · 2020-02-06T19:55:30Z

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to v1.12.13-hotfixes. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master. The circumstances where this is valid are very rare.

/cc @dnfield

christopherfujino · 2020-02-06T20:00:35Z

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to v1.12.13-hotfixes. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master. The circumstances where this is valid are very rare.

/cc @dnfield

This is a hotfix.

christopherfujino · 2020-02-07T18:08:00Z

Should this include #50315?

jmagman · 2020-02-08T00:12:20Z

.cirrus.yml


+    - name: verify_binaries_codesigned-macos # macos-only
+      # TODO(fujino): remove this `only_if` after https://github.com/flutter/flutter/issues/44372
+      only_if: "$CIRRUS_BRANCH == 'dev' || $CIRRUS_BRANCH == 'beta' || $CIRRUS_BRANCH == 'stable' || $CIRRUS_BRANCH =~ '.*hotfix.*'"


Why didn't verify_binaries_codesigned-macos run on this PR? We won't know if it passed until this is merged into stable, which is too late...

I tested this by commenting out the conditional and running the test. The reason it didn't run as is is because $CIRRUS_BRANCH is something like pull/50291 pre-submit. We'd catch a failure before before it landed in stable because hotfixes dont' get merged to stable until after CI is green on the hotfix branch.

Oh, but even better, I can check $CIRRUS_BASE_BRANCH != 'master'...

Will that catch random PRs off master that aren't codesigned too?

Well, the githubbot should change those to be on master. Not sure if the bot changing the base will re-trigger the cirrus jobs.

jmagman · 2020-02-08T00:17:24Z

dev/bots/codesign.dart

+      'test.');
+    exit(1);
+  }
+


Should we run flutter precache --no-android to make sure the iOS engine artifacts are actually present?

Good idea, I created this issue to track. For the sake of landing this hotfix, I won't cherry pick it here. This test will still catch when the batch codesigning job hasn't been run, as the dart sdk, libimobiledevice artifacts, and android gen snapshots are all cached by flutter doctor -v run in the setup_script (see https://cirrus-ci.com/task/6198934779461632).

jmagman

LGTM, my comments can be resolved on master.

tvolkert · 2020-02-08T17:58:18Z

What's with the "Minimum supported Gradle version is 5.4.1. Current version is 4.10.2" error in hostonly_devicelab_tests-2-macos?

It looks like the build_tests-macos may have failed because this isn't on master? If that's the case, can we issue a fix on master such that the next PR on a hotfix branch won't have the same problem?

dnfield · 2020-02-08T18:04:33Z

I'm bumping Gradle at #50388

christopherfujino · 2020-02-10T17:38:25Z

What's with the "Minimum supported Gradle version is 5.4.1. Current version is 4.10.2" error in hostonly_devicelab_tests-2-macos?

@tvolkert can I land this on a red hostonly_devicelab_tests-2-macos? As Dan linked, there is a pending Gradle upgrade upstream.

It looks like the build_tests-macos may have failed because this isn't on master? If that's the case, can we issue a fix on master such that the next PR on a hotfix branch won't have the same problem?

build_tests-macos was successful on a re-run. Not sure why the previous one failed, reading the logs it looked like it passed? And before that looked like a git cloning error.

dnfield · 2020-02-10T17:41:30Z

Shoudl we just pull in the gradle fixes to this branch once they land upstream, so future hotfixes won't have to be as complicate?

I'm also wondering if we should pull #49327 into this.

christopherfujino · 2020-02-10T17:49:35Z

Shoudl we just pull in the gradle fixes to this branch once they land upstream, so future hotfixes won't have to be as complicate?

I'm also wondering if we should pull #49327 into this.

The logcat fix makes sense.

As for #50388, @blasten it seems like you're saying that PR shouldn't affect users, is that correct? If so, then we might as hotfix that as well.

tvolkert · 2020-02-10T17:58:02Z

We could land this now and then land those other fixes on the flutter:v1.12.13-hotfixes branch before we tag the hotfix release.

christopherfujino · 2020-02-10T17:58:41Z

We could land this now and then land those other fixes on the flutter:v1.12.13-hotfixes branch before we tag the hotfix release.

sounds good, I'll do that now.

blasten · 2020-02-10T18:00:58Z

@christopherfujino That is correct. #50388 doesn't change behavior for end users.

…utter#50291)

update engine version

1915bee

fluttergithubbot changed the base branch from v1.12.13-hotfixes to master February 6, 2020 19:55

googlebot added the cla: yes label Feb 6, 2020

christopherfujino changed the base branch from master to v1.12.13-hotfixes February 6, 2020 19:56

christopherfujino force-pushed the hotfix-8 branch 5 times, most recently from 62c4bd6 to 17dbdb6 Compare February 7, 2020 00:19

christopherfujino force-pushed the hotfix-8 branch 2 times, most recently from 6aba911 to 8c82215 Compare February 7, 2020 21:57

cherry-pick codesign.dart integration test

7be27a1

jmagman mentioned this pull request Feb 7, 2020

flutter build ios fails: Failed to verify bitcode in Flutter.framework/Flutter on Xcode 10.3 #49787

Closed

jmagman and others added 2 commits February 7, 2020 15:26

Update minimum version to Xcode 11.0 (flutter#50371)

7d273a6

pin flutter/tests revision so customer_testing tests will pass

4bc011e

christopherfujino force-pushed the hotfix-8 branch from 8c82215 to 4bc011e Compare February 7, 2020 23:28

christopherfujino removed the work in progress; do not review label Feb 7, 2020

fluttergithubbot added the work in progress; do not review label Feb 7, 2020

christopherfujino changed the title ~~Hotfix 8~~ Hotfix 8 - sign binaries and increase minimum Xcode version to 11 Feb 7, 2020

christopherfujino requested review from jmagman and tvolkert February 7, 2020 23:56

christopherfujino marked this pull request as ready for review February 7, 2020 23:57

christopherfujino removed the work in progress; do not review label Feb 7, 2020

jmagman reviewed Feb 8, 2020

View reviewed changes

jmagman approved these changes Feb 8, 2020

View reviewed changes

christopherfujino merged commit afb2006 into flutter:v1.12.13-hotfixes Feb 10, 2020

christopherfujino deleted the hotfix-8 branch February 10, 2020 17:59

responilla07 pushed a commit to responilla07/flutter that referenced this pull request Jun 8, 2020

Hotfix 8 - sign binaries and increase minimum Xcode version to 11 (fl…

d93f7e0

…utter#50291)

github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2021

Hotfix 8 - sign binaries and increase minimum Xcode version to 11 #50291

Hotfix 8 - sign binaries and increase minimum Xcode version to 11 #50291

Uh oh!

Conversation

christopherfujino commented Feb 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Tests

Checklist

Breaking Change

Uh oh!

fluttergithubbot commented Feb 6, 2020

Uh oh!

christopherfujino commented Feb 6, 2020

Uh oh!

christopherfujino commented Feb 7, 2020

Uh oh!

jmagman Feb 8, 2020

Choose a reason for hiding this comment

Uh oh!

christopherfujino Feb 8, 2020

Choose a reason for hiding this comment

Uh oh!

christopherfujino Feb 8, 2020

Choose a reason for hiding this comment

Uh oh!

jmagman Feb 8, 2020

Choose a reason for hiding this comment

Uh oh!

christopherfujino Feb 8, 2020

Choose a reason for hiding this comment

Uh oh!

jmagman Feb 8, 2020

Choose a reason for hiding this comment

Uh oh!

christopherfujino Feb 8, 2020

Choose a reason for hiding this comment

Uh oh!

jmagman left a comment

Choose a reason for hiding this comment

Uh oh!

tvolkert commented Feb 8, 2020

Uh oh!

dnfield commented Feb 8, 2020

Uh oh!

christopherfujino commented Feb 10, 2020

Uh oh!

dnfield commented Feb 10, 2020

Uh oh!

christopherfujino commented Feb 10, 2020

Uh oh!

tvolkert commented Feb 10, 2020

Uh oh!

christopherfujino commented Feb 10, 2020

Uh oh!

blasten commented Feb 10, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

christopherfujino commented Feb 6, 2020 •

edited

Loading