Skip to content

Remove ideviceinfo, idevice_id artifacts #50248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmagman merged 1 commit into from
Feb 6, 2020
Merged

Remove ideviceinfo, idevice_id artifacts #50248

jmagman merged 1 commit into from
Feb 6, 2020

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Feb 6, 2020

Description

Remove ideviceinfo and idevice_id code. Made dead by #49854.

Tests

Updated cache_test, and mac_test.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

@jmagman jmagman added c: contributor-productivity Team-specific productivity, code health, technical debt. platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Feb 6, 2020
@jmagman jmagman self-assigned this Feb 6, 2020
@jmagman
Copy link
Member Author

jmagman commented Feb 6, 2020

This needs a corresponding CL to remove g3assets.ideviceinfo and g3assets.idevice_id.

@jmagman jmagman changed the title WIP Remove ideviceinfo, idevice_id artifacts Remove ideviceinfo, idevice_id artifacts Feb 6, 2020
@zanderso
Copy link
Member

zanderso commented Feb 6, 2020

@christopherfujino Can the infra recipe be updated to avoid building these?

@christopherfujino
Copy link
Contributor

christopherfujino commented Feb 6, 2020 •
edited
Loading

@christopherfujino Can the infra recipe be updated to avoid building these?

yup, I opened #50299 to track.

@christopherfujino christopherfujino mentioned this pull request Feb 6, 2020
Closed
christopherfujino
christopherfujino approved these changes Feb 6, 2020
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks GREAT to me!

@jmagman jmagman merged commit a9b8d36 into flutter:master Feb 6, 2020
@jmagman jmagman deleted the remove-idevice branch February 6, 2020 23:50
@jmagman jmagman mentioned this pull request Mar 16, 2021
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@zanderso zanderso zanderso approved these changes

+1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jmagman @zanderso @christopherfujino @googlebot