Revert "install goldctl in docker build" #50088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7a13d8a.
fluttergithubbot
added
the
c: contributor-productivity
Contributor
Author
|
This is the first PR I've seen today to not flake at least once on goldctl for linux. I'm going to land it TBR to try to make the tree healthier. If we see the flake happening again on Linux we should revert it. The build is actually green per cirrus, dashboard just hasn't caught up yet. |
Merged
dnfield
added a commit
that referenced
this pull request
Feb 4, 2020
13 tasks
dnfield
added a commit
that referenced
this pull request
Feb 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #46640
Speculative fix for flakiness discussed in #49917
Theory is that because goldctl is no longer getting the latest version on each run, the version currently used on linux is too stale and suffering from occasional bugs around authorization. This is the primary difference right now between the Windows and Mac builds, which are not flaking similarly and are running on latest.