[flutter_tools] Fix crash on null Android apiVersion #50029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
added
tool
| final int apiVersion = (String v) { | ||
| // If the API version string isn't found, conservatively assume that the | ||
| // version is less recent than the one we're looking for. | ||
| return v == null ? kLollipopVersionCode - 1 : int.tryParse(v); |
Member
There was a problem hiding this comment.
Do we know anything about the situations where apiVersion is showing up as null?
Is something going wrong when the tool tries to run adb getprop, or is the ro.build.version.sdk property actually missing?
Member
Author
There was a problem hiding this comment.
It's most likely that this property is just missing. If adb getprop had failed more severely, then the tool would not have gotten this far. In particular, it wouldn't have been able to figure out the device.targetPlatform:
which boils down to a getprop call on Android:
|
LGTM + @jason-simmons comment |
blasten
approved these changes
Feb 3, 2020
13 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
getpropcan come back without an API version. In that case the getter will be null. Previously this was used only for filling out aString, but recently a change also used it to decide what flags to pass tologcat. This change makes the flag logic handle the null case.Related Issues
Most frequent tool crasher on dev.
Tests
I added the following tests:
Added tests to android_device_test.dart.
Breaking Change
Did any tests fail when you ran them? Please read [Handling breaking changes].