Skip to content

Conversation

@tvolkert
Copy link
Contributor

@tvolkert tvolkert commented Jan 24, 2020

@fluttergithubbot fluttergithubbot changed the base branch from v1.12.13-hotfixes to master January 24, 2020 18:55
@fluttergithubbot

This comment has been minimized.

@fluttergithubbot fluttergithubbot added engine flutter/engine related. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Jan 24, 2020
@tvolkert tvolkert changed the base branch from master to v1.12.13-hotfixes January 24, 2020 18:55
@tvolkert tvolkert requested review from GaryQian and dnfield January 24, 2020 18:55
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvolkert
Copy link
Contributor Author

#47804
#47164

@GaryQian
Copy link
Contributor

Changes regarding Revert "Track and use fallback TextAffinity for null affinity platform TextSelections. (#44622)" LGTM

@dnfield
Copy link
Contributor

dnfield commented Jan 24, 2020

I don't quite understand why, but it's failing when it tries to global activate dartdoc 0.29.1

Bumping it to 0.29.3 (the current version on master) is not failing at the same step. bd25f70 is the commit to cherrypick.

@dnfield
Copy link
Contributor

dnfield commented Jan 25, 2020

@tvolkert this is actually green on citrus. Should be safe to land now

@tvolkert tvolkert merged commit 9f5ff23 into flutter:v1.12.13-hotfixes Jan 27, 2020
@tvolkert tvolkert deleted the v1.12.13-hotfixes branch January 27, 2020 06:38
responilla07 pushed a commit to responilla07/flutter that referenced this pull request Jun 8, 2020
* flutter/engine@a677925 Cherry pick infra testing updates into hotfixes
* flutter/engine@b1bb773 Raise API level for reportFullyDrawn
* flutter/engine@a433ed9 v1.12.13+hotfix.7 cherry-picks
  * google/skia@a640745 Disable QCOM_tiled_rendering while we wait for test devices
  * flutter/engine@bcb8267 Revert "Do not default to downstream affinity on iOS insertText"
* d345a3b Revert "Track and use fallback TextAffinity for null affinity platform TextSelections. (flutter#44622)"
* bd25f70 Upgrade dartdoc to 0.29.3
* 7915e58 Change firebase Pixel3 version from Q-beta3 to 29
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. engine flutter/engine related. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants