Skip to content

Revert "Do not rebuild Routes when a new opaque Route is pushed on top" #49366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bparrishMines merged 1 commit into from
Jan 23, 2020
Merged

Revert "Do not rebuild Routes when a new opaque Route is pushed on top" #49366

bparrishMines merged 1 commit into from
Jan 23, 2020

Conversation

@bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented Jan 23, 2020

Reverts #48900

Causing some failures in the Flutter Roll

@fluttergithubbot fluttergithubbot added f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jan 23, 2020
@bparrishMines bparrishMines merged commit 52c665d into master Jan 23, 2020
@bparrishMines bparrishMines deleted the revert-48900-theatre2 branch January 23, 2020 19:32
goderbauer added a commit that referenced this pull request Jan 23, 2020
@goderbauer
Revert "Revert "Do not rebuild Routes when a new opaque Route is push…
190eb87 
…ed on top (#48900)" (#49366)"

This reverts commit 52c665d.
@goderbauer goderbauer mentioned this pull request Jan 23, 2020
Merged
@goderbauer
Copy link
Member

goderbauer commented Jan 23, 2020

LGTM

Turns out the problem here was missing calls to setState in the user's code. I am going to re-apply this PR after the issues have been fixed in the upstream code base.

goderbauer added a commit that referenced this pull request Jan 23, 2020
@goderbauer
Revert "Revert "Do not rebuild Routes when a new opaque Route is push…
e39f87a 
…ed on top (#48900)" (#49366)"

This reverts commit 52c665d.
goderbauer added a commit that referenced this pull request Jan 24, 2020
@goderbauer
Revert "Revert "Do not rebuild Routes when a new opaque Route is push…
c9efbd2 
…ed on top (#48900)" (#49366)"

This reverts commit 52c665d.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cbracken cbracken Awaiting requested review from cbracken

@goderbauer goderbauer Awaiting requested review from goderbauer

Assignees

No one assigned

Labels

f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bparrishMines @goderbauer @googlebot @fluttergithubbot