Skip to content

Conversation

@jason-simmons
Copy link
Member

Fixes #47609
Fixes #47112

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jan 23, 2020
@jason-simmons jason-simmons requested a review from blasten January 23, 2020 01:45
Copy link

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing this issue.

Copy link
Member

@zanderso zanderso Jan 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With await, the .then is redundant. You can say

final Process process = await processUtils.start(...);
_process = process;
...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flutter version >1.9.1 not working on Android 4.4 and lower Crashing on Android Kitkat (4.4)

5 participants