Skip to content

Conversation

@a14n
Copy link
Contributor

@a14n a14n commented Jan 20, 2020

Description

Add missing space in adjacent strings

Related Issues

Fixes #48090

Tests

None

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.

@fluttergithubbot fluttergithubbot added f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jan 20, 2020
@a14n a14n force-pushed the missing-spaces-adjacent-strings branch 4 times, most recently from bc2860a to b7764b3 Compare January 20, 2020 14:11
@a14n a14n force-pushed the missing-spaces-adjacent-strings branch 3 times, most recently from 6729b1c to 5396831 Compare January 21, 2020 09:19
@a14n a14n force-pushed the missing-spaces-adjacent-strings branch from 5396831 to 88d6227 Compare January 21, 2020 09:36
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d
Nice!

@fluttergithubbot fluttergithubbot merged commit 3800bb7 into flutter:master Jan 22, 2020
@a14n a14n deleted the missing-spaces-adjacent-strings branch January 22, 2020 04:55
if (!mounted) {
throw FlutterError(
'AutomaticKeepAlive handle triggered after AutomaticKeepAlive was disposed.'
'AutomaticKeepAlive handle triggered after AutomaticKeepAlive was disposed. '
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should actually be a newline (see docs for FlutterError constructor)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in #49280

@Hixie
Copy link
Contributor

Hixie commented Jan 22, 2020

This is fantastic, thanks @a14n!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"No MaterialLocalizations found" exception has a typo

5 participants