Reland "[flutter_tools] Removes the need of a no-op plugin implementations #48614" #49085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
c: contributor-productivity
franciscojma86
commented
Jan 17, 2020
| result['date_created'] = systemClock.now().toString(); | ||
| result['version'] = flutterVersion.frameworkVersion; | ||
|
|
||
| // Only notify if the plugins list has changed. [date_created] will always be different, |
Contributor
Author
There was a problem hiding this comment.
This logic had to be updated. It was always returning true, since date_created was always different on each file. This caused the podfiles to be invalidated every time.
franciscojma86
commented
Jan 17, 2020
| FlutterVersion: () => mockVersion | ||
| }); | ||
|
|
||
| testUsingContext('No changes to the plugin list does not invalidate the Cocoapod lockfiles', () { |
Contributor
Author
There was a problem hiding this comment.
This tests the new change, where podfiles shouldn't be invalidated if plugins didn't change
This was referenced Jan 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reland of #48614 with updated logic and test.
Comments on PR