Add macOS Tests (Part 2: Material) #48996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
f: material design
gspencergoog
force-pushed
the
macos_tests_material
branch
from
4120f19 to
fd0e679
Compare
gspencergoog
force-pushed
the
macos_tests_material
branch
from
fd0e679 to
8a1b1bc
Compare
justinmc
approved these changes
Jan 16, 2020
| expect(topAfterScroll.dy, lessThan(10.0)); | ||
| expect(topAfterScroll.dy, greaterThan(-50.0)); | ||
| }); | ||
| }, variant: const TargetPlatformVariant(<TargetPlatform>{ TargetPlatform.android, TargetPlatform.iOS, TargetPlatform.macOS })); |
Contributor
There was a problem hiding this comment.
Very cool that this allows you to remove all of the platform specific code above 👍
| expect(find.byType(CupertinoButton), findsNothing); | ||
| }); | ||
|
|
||
| // TODO(gspencergoog): Add in TargetPlatform.macOS in the line below when we figure out what global state is leaking. |
Contributor
There was a problem hiding this comment.
Hmm that's scary. No ideas off the top of my head.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This contains the test changes for adding
TargetPlatform.macOS, which was done in #43457.The main goal of this PR is to enable tests in the material library that are currently running only on iOS to also run on macOS, but only for the tests where that makes sense. For instance, we don't run any of the haptic feedback tests on macOS.
Related Issues
Tests
Breaking Change