Skip to content

RefreshIndicator dismiss transition, remain visible during refresh, etc #4844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
HansMuller merged 4 commits into from
Jul 7, 2016
Merged

RefreshIndicator dismiss transition, remain visible during refresh, etc #4844

HansMuller merged 4 commits into from
Jul 7, 2016

Conversation

@HansMuller
Copy link
Contributor

@HansMuller HansMuller commented Jul 7, 2016

  • The refresh indicator now slides out of view if it wasn't dragged far enough to trigger the refresh callback.
  • Once a refresh is underway, the indicator stays put, even if the underlying scrollable is scrolled.
  • The implementation now keeps track of the overscroll distance (_dragOffset) itself. The refresh indicator will appear even if overscrolling isn't possible.

Fixes #4829
Fixes #4831
Fixes #4834

abarth
abarth reviewed Jul 7, 2016
View reviewed changes
packages/flutter/lib/src/material/refresh_indicator.dart Outdated
final double scrollOffset = scrollable.scrollOffset;
switch (config.location) {
case RefreshIndicatorLocation.top:
return scrollOffset <= minScrollOffset;
Copy link
Contributor

@abarth abarth Jul 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra space :)

@abarth
Copy link
Contributor

abarth commented Jul 7, 2016

LGTM

@HansMuller HansMuller merged commit 0f15263 into flutter:master Jul 7, 2016
@HansMuller HansMuller deleted the refresh_indicator_refresh branch July 7, 2016 23:30
cdotstout pushed a commit to cdotstout/flutter that referenced this pull request Apr 3, 2018
@cbracken
Fix GPUSurfaceGL includes on macOS (flutter#4844)
9b83765 
macOS doesn't include GLES support.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

2 participants

@HansMuller @abarth