Skip to content

Conversation

@flar
Copy link
Contributor

@flar flar commented Dec 27, 2019

PR #47742 included changes to parse the timelines that are implemented in the Dart changes in this Engine commit. Manually rolling the engine version to unbreak the build.

@fluttergithubbot fluttergithubbot added the engine flutter/engine related. See also e: labels. label Dec 27, 2019
@flar flar requested a review from franciscojma86 December 27, 2019 22:05
@flar
Copy link
Contributor Author

flar commented Dec 27, 2019

Confirmed that tiles_scroll_perf_ios__timeline_summary fails due to "durations is empty" before this change and succeeds after...

@franciscojma86
Copy link
Contributor

Landing on red to fix the build

@franciscojma86 franciscojma86 merged commit 4f23c43 into flutter:master Dec 27, 2019
@flar flar deleted the manual-engine-roll-to-fix-timelines branch September 4, 2020 19:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

engine flutter/engine related. See also e: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants