Reland 39919 CupertinoPicker #47837
Merged
Reland 39919 CupertinoPicker #47837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
f: cupertino
justinmc
approved these changes
Dec 26, 2019
Contributor
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
LGTM, just 2 nitpicks.
Should this be marked as a breaking change?
| untransformedPaintingCoordinates.dx, | ||
| -_topScrollMarginExtent); | ||
| untransformedPaintingCoordinates.dx, | ||
| -_topScrollMarginExtent |
Contributor
There was a problem hiding this comment.
Comma here at the end of the line.
| Matrix4 cylindricalTransform, | ||
| Offset offsetToCenter, | ||
| ) { | ||
| // Paint child with cylindrically. |
Contributor
There was a problem hiding this comment.
Nit: Should this just be "Paint child cylindrically."? Or does it mean to paint it with the "cylindrically" method? Also see line 956 below.
Contributor
Author
There was a problem hiding this comment.
Forgot to delete it I guess.
Contributor
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reland a reverted breaking change #39919.
/cc @liyuqian.
Related Issues
#41654
Tests
I added the following tests:
Replace this with a list of the tests that you added as part of this PR. A change in behaviour with no test covering it
will likely get reverted accidentally sooner or later. PRs must include tests for all changed/updated/fixed behaviors. See Test Coverage.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.