Skip to content

Scrollable dropdown, dropdown underline cosmetics - #4766

Merged
HansMuller merged 4 commits into
flutter:masterfrom
HansMuller:dropdown_underline
Jun 27, 2016
Merged

HansMuller merged 4 commits into
flutter:masterfrom
HansMuller:dropdown_underline

Conversation

@HansMuller

Copy link
Copy Markdown
Contributor
  • Added support for scrolling to dropdown menus.
  • Added a scrolling dropdown demo to the gallery.
  • Adjusted DropDownButtons' layout and colors to better match the spec.

Fixes #4664
Fixes #2243


import 'package:flutter/widgets.dart';


Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spurious lines

@abarth

abarth commented Jun 27, 2016

Copy link
Copy Markdown
Contributor

LGTM

@HansMuller
HansMuller merged commit 08bf1b6 into flutter:master Jun 27, 2016
aam added a commit to aam/flutter that referenced this pull request Mar 10, 2018
Changes since last roll:
```
9a98143 Roll dart to c080951d45e79cd25df98036c4be835b284a269c. (flutter#4767)
e74e8b3 [async] Update includes of async headers to new path (flutter#4760)
e2c4b27 Use Dart 2 camel case constants in the engine Dart libraries (flutter#4766)
9c1e484 Updates for Fuchsia roll. (flutter#4765)
14c940e Switch from fxl::Mutex to std::mutex (flutter#4764)
debf82c Roll Garnet (flutter#4759)
5bffdef Use weak pointers to the accesibility bridge from objects vended to the UIKit accessibility framework. (flutter#4761)
```
aam added a commit to aam/flutter that referenced this pull request Mar 12, 2018
Changes since last roll:
```
b6df7a6 Roll dart to 290c576264faa096a0b3206c71b2435309d9f904. (flutter#4771)
a6764db Add sources for Fuchsia target. (flutter#4763)
2d59006 [fuchsia] Remove unused header file. (flutter#4769)
9717063 Revert "Roll dart to c080951d45e79cd25df98036c4be835b284a269c. (flutter#4767)" (flutter#4768)
9a98143 Roll dart to c080951d45e79cd25df98036c4be835b284a269c. (flutter#4767)
e74e8b3 [async] Update includes of async headers to new path (flutter#4760)
e2c4b27 Use Dart 2 camel case constants in the engine Dart libraries (flutter#4766)
9c1e484 Updates for Fuchsia roll. (flutter#4765)
14c940e Switch from fxl::Mutex to std::mutex (flutter#4764)
debf82c Roll Garnet (flutter#4759)
5bffdef Use weak pointers to the accesibility bridge from objects vended to the UIKit accessibility framework. (flutter#4761)
```
aam added a commit that referenced this pull request Mar 12, 2018
* Roll engine to b6df7a6.

Changes since last roll:
```
b6df7a6 Roll dart to 290c576264faa096a0b3206c71b2435309d9f904. (#4771)
a6764db Add sources for Fuchsia target. (#4763)
2d59006 [fuchsia] Remove unused header file. (#4769)
9717063 Revert "Roll dart to c080951d45e79cd25df98036c4be835b284a269c. (#4767)" (#4768)
9a98143 Roll dart to c080951d45e79cd25df98036c4be835b284a269c. (#4767)
e74e8b3 [async] Update includes of async headers to new path (#4760)
e2c4b27 Use Dart 2 camel case constants in the engine Dart libraries (#4766)
9c1e484 Updates for Fuchsia roll. (#4765)
14c940e Switch from fxl::Mutex to std::mutex (#4764)
debf82c Roll Garnet (#4759)
5bffdef Use weak pointers to the accesibility bridge from objects vended to the UIKit accessibility framework. (#4761)
```
cdotstout pushed a commit to cdotstout/flutter that referenced this pull request Apr 3, 2018
DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this pull request May 14, 2018
* Roll engine to b6df7a6.

Changes since last roll:
```
b6df7a6 Roll dart to 290c576264faa096a0b3206c71b2435309d9f904. (flutter#4771)
a6764db Add sources for Fuchsia target. (flutter#4763)
2d59006 [fuchsia] Remove unused header file. (flutter#4769)
9717063 Revert "Roll dart to c080951d45e79cd25df98036c4be835b284a269c. (flutter#4767)" (flutter#4768)
9a98143 Roll dart to c080951d45e79cd25df98036c4be835b284a269c. (flutter#4767)
e74e8b3 [async] Update includes of async headers to new path (flutter#4760)
e2c4b27 Use Dart 2 camel case constants in the engine Dart libraries (flutter#4766)
9c1e484 Updates for Fuchsia roll. (flutter#4765)
14c940e Switch from fxl::Mutex to std::mutex (flutter#4764)
debf82c Roll Garnet (flutter#4759)
5bffdef Use weak pointers to the accesibility bridge from objects vended to the UIKit accessibility framework. (flutter#4761)
```
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DropDownButton underline is a long way away from the text it underlines. Scrolling Menus

2 participants