Repository navigation
Push nested routes - #4763
Push nested routes#4763devoncarew wants to merge 4 commits into
Conversation
|
@abarth this is hitting your recent work on moving focus. The problem is that we are pushing multiple routes on startup, and so only one is marked as "initial", so we're going down the non-initial codepath, which is expecting to already have been built at least once. |
| name: route, | ||
| isInitialRoute: isFirst | ||
| ))); | ||
| isFirst = false; |
There was a problem hiding this comment.
What happens if you pass true for isInitialRoute for all of these? You don't want them to animate in either, which means you want them to all be "initial". (We should probably rename isInitialRoute to something that makes sense in this context).
|
It gets a bit further along - the app starts up and displays the main screen, but I get an exception later on - perhaps when responding to the |
|
If I insert a delay before pushing routes (apart from the first segment), I don't see the exception. Something like: |
|
I'm not sure we want to use asynchrony here. Can you explain a bit more about what you're trying to achieve? You'd like to start the app up with some history already in place? |
|
I might have fixed the hero quest issue in #4769 |
Yup, if the initial route is I don't think the asynchrony is a good solution here, more me experimenting and trying to get things to work. I'll try a simpler solution w/ your hero fix. |
Changes since last roll: ``` b6df7a6 Roll dart to 290c576264faa096a0b3206c71b2435309d9f904. (flutter#4771) a6764db Add sources for Fuchsia target. (flutter#4763) 2d59006 [fuchsia] Remove unused header file. (flutter#4769) 9717063 Revert "Roll dart to c080951d45e79cd25df98036c4be835b284a269c. (flutter#4767)" (flutter#4768) 9a98143 Roll dart to c080951d45e79cd25df98036c4be835b284a269c. (flutter#4767) e74e8b3 [async] Update includes of async headers to new path (flutter#4760) e2c4b27 Use Dart 2 camel case constants in the engine Dart libraries (flutter#4766) 9c1e484 Updates for Fuchsia roll. (flutter#4765) 14c940e Switch from fxl::Mutex to std::mutex (flutter#4764) debf82c Roll Garnet (flutter#4759) 5bffdef Use weak pointers to the accesibility bridge from objects vended to the UIKit accessibility framework. (flutter#4761) ```
* Roll engine to b6df7a6. Changes since last roll: ``` b6df7a6 Roll dart to 290c576264faa096a0b3206c71b2435309d9f904. (#4771) a6764db Add sources for Fuchsia target. (#4763) 2d59006 [fuchsia] Remove unused header file. (#4769) 9717063 Revert "Roll dart to c080951d45e79cd25df98036c4be835b284a269c. (#4767)" (#4768) 9a98143 Roll dart to c080951d45e79cd25df98036c4be835b284a269c. (#4767) e74e8b3 [async] Update includes of async headers to new path (#4760) e2c4b27 Use Dart 2 camel case constants in the engine Dart libraries (#4766) 9c1e484 Updates for Fuchsia roll. (#4765) 14c940e Switch from fxl::Mutex to std::mutex (#4764) debf82c Roll Garnet (#4759) 5bffdef Use weak pointers to the accesibility bridge from objects vended to the UIKit accessibility framework. (#4761) ```
* Roll engine to b6df7a6. Changes since last roll: ``` b6df7a6 Roll dart to 290c576264faa096a0b3206c71b2435309d9f904. (flutter#4771) a6764db Add sources for Fuchsia target. (flutter#4763) 2d59006 [fuchsia] Remove unused header file. (flutter#4769) 9717063 Revert "Roll dart to c080951d45e79cd25df98036c4be835b284a269c. (flutter#4767)" (flutter#4768) 9a98143 Roll dart to c080951d45e79cd25df98036c4be835b284a269c. (flutter#4767) e74e8b3 [async] Update includes of async headers to new path (flutter#4760) e2c4b27 Use Dart 2 camel case constants in the engine Dart libraries (flutter#4766) 9c1e484 Updates for Fuchsia roll. (flutter#4765) 14c940e Switch from fxl::Mutex to std::mutex (flutter#4764) debf82c Roll Garnet (flutter#4759) 5bffdef Use weak pointers to the accesibility bridge from objects vended to the UIKit accessibility framework. (flutter#4761) ```
Some work towards #4702.
When I run this against flutter_gallery with the route
/buttons, I get the following exception (on pushing/buttons, after pushing/):@Hixie, does anything jump out at you here? Something simple? Perhaps something I'm doing that's not expected by the framework?