Skip to content

Add Border.symmetric constructor - #47523

Merged
fluttergithubbot merged 1 commit into
flutter:masterfrom
KagurazakaHanabi:Hanabi-patch-4
Jan 6, 2020
Merged

fluttergithubbot merged 1 commit into
flutter:masterfrom
KagurazakaHanabi:Hanabi-patch-4

Conversation

@KagurazakaHanabi

Copy link
Copy Markdown

Related Issues

Closes #45524

Tests

I added the following tests:

  • Border.symmetric constructor

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.

@fluttergithubbot fluttergithubbot added the framework flutter/packages/flutter repository. See also f: labels. label Dec 20, 2019

@goderbauer goderbauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvolkert

Copy link
Copy Markdown
Contributor

Aren't vertical and horizontal backwards here? The vertical borders (the lines running vertically) are the left and right borders, whereas the horizontal ones are the top and bottom...

@tvolkert

Copy link
Copy Markdown
Contributor

I filed #61470 and plan to fix.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Constructor of Border: Border.symmetric

5 participants