Repository navigation
Support for ImageFiltered widget to apply ImageFilter to children. - #47489
Conversation
fluttergithubbot
added
the
framework
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
I also still need to create some tests. |
|
The tests will fail until the engine changes roll into framework, but here are the golden image results I'm expecting... |
|
All implementations of the back end for this widget have landed in the Engine repo, and we're just waiting for those commits to roll to the framework repo to finalize this PR. Here is a screenshot of the new ImageFiltered running on Chrome (note that the BackdropFilter doesn't produce a blur yet on Chrome, it simply dims the background, so the ImageFiltered widget will become a preferred way to blur a background if you can use it in your app). |
|
LGTM from the engine interaction standpoint. I left some comments on the API design, but consider them non-blocking. API LGTM if LGT @Hixie. |
38792c2 to
a52f755
Compare
|
The engine implementation for C++ has rolled into the framework repo with web stubs, and the web implementation that removes the stubs is staged in the engine roller (just waiting for the tree to go green to be rolled), so I am removing the WIP label. This PR should be ready to go. |
a52f755 to
8ac22a9
Compare
|
|
Framework counterpart to flutter-team-archive/engine#14491
Fixes #13489
The engine PR for the C++ engine has landed, and the web_ui version of the implementation should land in the next few days. This PR cannot be pushed until minimally flutter-team-archive/engine@929b1ed is rolled into the framework repo and it should also wait until the fix for #47163 to roll as well.
Marked as WIP until the engine rolls happen, but it is otherwise ready for reviews.