Repository navigation
Gallery about box: state Flutter's status and link to our website - #4746
Conversation
There was a problem hiding this comment.
I'm surprised you're using a shortened link instead of just https://github.com/flutter/flutter/tree/master/examples/flutter_gallery. Does the shortened link allow you to change it after the fact or some other value-add?
There was a problem hiding this comment.
I made it short because the long link looks terrible. A side benefit is that it gool.gl reports usage. If it's possible to change the link's value, it's not obvious (to me) from the goo.gl UI.
There was a problem hiding this comment.
Oh. I see. You're showing the URL itself in the dialog.
On Friday, June 24, 2016, Hans Muller [email protected] wrote:
In examples/flutter_gallery/lib/gallery/drawer.dart
#4746 (comment):
"developers build high-performance, high-fidelity, mobile ""apps for iOS and Android from a single codebase. This ""gallery is a preview of Flutter's many widgets, behaviors, ""animations, layouts, and more. Learn more about Flutter at "),new LinkTextSpan(style: aboutLinkStyle,url: 'https://flutter.io'),new TextSpan(style: aboutTextStyle,text: ".\n\nTo see the source code for this app, please visit "),new LinkTextSpan(style: aboutLinkStyle,url: 'https://goo.gl/iv1p4G'I made it short because the long link looks terrible. A side benefit is
that it gool.gl reports usage. If it's possible to change the link's
value, it's not obvious (to me) from the goo.gl UI.—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/pull/4746/files/3b77b85fe28882430d07f8f985e86a71a64ba13d#r68470524,
or mute the thread
https://github.com/notifications/unsubscribe/ALTvi6il2KRa8mH1ebNWgiECXL4pckFmks5qPFaRgaJpZM4I-KbY
.
There was a problem hiding this comment.
We could make a short link on flutter.io itself. It'd be prettier.
|
|
3b77b85 to
7665fb7
Compare
…oid (flutter#4746) * deprecate snapshot_override, which is an obsolete predecessor of hot reload * give the APKAssetProvider to the engine in the initial call to RunBundle * later calls to Engine::RunBundleAndSource or Engine::SetAssetBundlePath will replace the APK asset provider with a DirectoryAssetBundle that uses the newly pushed assets
Fixes #4512
Fixes #4584