WIP Create .flutter-plugins file per platform #47258

franciscojma86 · 2019-12-17T22:59:49Z

Description

Creates a .flutter-plugins and a .flutter-plugins-dependencies file for each platform project instead of in the Flutter root project for all platforms except for Android.

Related Issues

#46618

Tests

Tests remaining

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I signed the [CLA].
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I updated/added relevant documentation (doc comments with ///).
All existing and new tests are passing.
The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read [Handling breaking changes].

No, no existing tests failed, so this is not a breaking change.
Yes, this is a breaking change. If not, delete the remainder of this section.
- I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
- I got input from the developer relations team, specifically from: Replace with the names of who gave advice
- I wrote a migration guide: Replace with a link to your migration guide

fluttergithubbot · 2019-12-17T22:59:52Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

…ins2

jmagman · 2019-12-30T23:14:52Z

packages/flutter_tools/templates/cocoapods/Podfile-ios-objc

  system('rm -rf .symlinks')
  system('mkdir -p .symlinks/plugins')
-  plugin_pods = parse_KV_file('../.flutter-plugins')
+  plugin_pods = parse_KV_file('./Flutter/.flutter-plugins')


The Podfiles aren't owned by Flutter, and they get generated only when the app is created. So existing Podfiles are going to expect '../.flutter-plugins' and won't get this change without a migration.

Agreed. I am still generating the current file at the same location to avoid breaking existing apps. I'll add a warning message if they are using the "old" podfile so the user can delete it and auto-generate it again.

Can you copy/make the symlinks in this Ruby file from the old one if the old directory is present and the new one isn't so they don't need to regenerate anything, and a pod install won't just fail? The unless block right above is doing a similar one-time cp migration

Or something like this so they know what to do if the new file doesn't exist:

plugin_file = File.join(__dir__, 'Flutter', '.flutter-plugins') unless File.exist?(plugin_file) raise "Flutter/.flutter-plugins must exist. If you're running pod install manually, make sure flutter pub get is executed first" end plugin_pods = parse_KV_file(plugin_file)

codecov · 2020-01-07T22:12:50Z

Codecov Report

Merging #47258 into master will increase coverage by 1.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #47258      +/-   ##
==========================================
+ Coverage   63.03%    64.2%   +1.17%     
==========================================
  Files         204      205       +1     
  Lines       20919    20777     -142     
==========================================
+ Hits        13186    13340     +154     
+ Misses       7733     7437     -296

Flag	Coverage Δ
#flutter_tool	`64.2% <0%> (+1.17%)`	⬆️

Impacted Files	Coverage Δ
packages/flutter_tools/lib/src/desktop_device.dart	`19.23% <0%> (-48.08%)`	⬇️
...utter_tools/lib/src/build_runner/build_script.dart	`0% <0%> (-38.19%)`	⬇️
packages/flutter_tools/lib/src/base/config.dart	`79.16% <0%> (-16.49%)`	⬇️
...ckages/flutter_tools/lib/src/base/async_guard.dart	`83.33% <0%> (-11.12%)`	⬇️
...utter_tools/lib/src/reporting/github_template.dart	`78.43% <0%> (-10.04%)`	⬇️
...er_tools/lib/src/commands/build_ios_framework.dart	`6.52% <0%> (-5.05%)`	⬇️
packages/flutter_tools/lib/src/context_runner.dart	`70.68% <0%> (-1.73%)`	⬇️
packages/flutter_tools/lib/src/device.dart	`65.92% <0%> (-1.12%)`	⬇️
packages/flutter_tools/lib/src/web/compile.dart	`68.75% <0%> (-0.95%)`	⬇️
...tools/lib/src/base/error_handling_file_system.dart	`87.3% <0%> (-0.94%)`	⬇️
... and 97 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 134c2ff...17e113e. Read the comment docs.

googlebot · 2020-01-07T22:13:15Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

googlebot · 2020-01-07T22:13:34Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

googlebot · 2020-01-07T22:28:39Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

jmagman · 2020-01-08T02:42:14Z

Re: "get fetches packages and injects plugin" failure:

C:\Users\ContainerAdministrator\AppData\Local\Temp\flutter_tools_packages_test.23547105-31a1-11ea-aad5-d9e98a4a8e96\flutter_project/.ios/Podfile should exist, but does not

in _regenerateFromTemplateIfNeeded it's returning immediately instead of copying over everything from the template. toolingChanged and pubspecChanged are both false on this change at that point, but true on master.

franciscojma86 · 2020-01-21T21:28:24Z

Closing in favor of #49085. The changes to the templates will be done in a separate PR

franciscojma86 added 10 commits December 13, 2019 16:16

Add platform project

326a0fa

Starts creating the plugins file per project

c124e7b

Almost all in, need popfiles

d489a2a

Testing

2e63a54

typo

3611bd8

Use same

f29ec58

Change dependencies addresss

1f02548

Works on all platd

3aa728b

Simplify

5fe9eab

Clean a bit

fd54ae1

franciscojma86 requested a review from jmagman as a code owner December 17, 2019 22:59

fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Dec 17, 2019

googlebot added the cla: yes label Dec 17, 2019

franciscojma86 removed the request for review from jmagman December 17, 2019 23:01

Remove filter option

71ed112

franciscojma86 mentioned this pull request Dec 18, 2019

Allow plugins not to support macOS #46618

Closed

zanderso added the work in progress; do not review label Dec 19, 2019

franciscojma86 and others added 12 commits December 19, 2019 11:24

Add platform project

895ca04

Starts creating the plugins file per project

f078e2a

Almost all in, need popfiles

64c5300

Testing

d16e51f

typo

d9b02da

Use same

41bdcc4

Change dependencies addresss

f4e6638

Works on all platd

4c648e1

Simplify

212567d

Clean a bit

4076da8

Remove filter option

abb3369

Refactor for legacy

b9ea0c5

Merge branch 'plugins' of github.com:franciscojma86/flutter into plug…

9236c92

…ins2

franciscojma86 force-pushed the plugins branch from 71ed112 to b9ea0c5 Compare December 19, 2019 23:18

franciscojma86 and others added 4 commits December 19, 2019 15:50

Removoe project from interface

8cfa513

Add first tests

3b9bb8c

First 3 tests work

02bafd9

All tests pass

82a2fea

jmagman reviewed Dec 30, 2019

View reviewed changes

Merge branch 'plugins' into test

d66adc0

franciscojma86 requested a review from christopherfujino as a code owner January 7, 2020 22:12

googlebot added cla: no and removed cla: yes labels Jan 7, 2020

franciscojma86 force-pushed the plugins branch from 53a65fe to d66adc0 Compare January 7, 2020 22:28

googlebot added cla: yes and removed cla: no labels Jan 7, 2020

Add final

17e113e

franciscojma86 removed the request for review from christopherfujino January 8, 2020 00:51

franciscojma86 mentioned this pull request Jan 14, 2020

[flutter_tools] Removes the need of a no-op plugin implementations #48614

Merged

9 tasks

This was referenced Jan 18, 2020

Allow plugins to not support Android #39657

Closed

Allow plugins to not support iOS #39659

Closed

franciscojma86 closed this Jan 21, 2020

github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

WIP Create .flutter-plugins file per platform #47258

WIP Create .flutter-plugins file per platform #47258

Uh oh!

franciscojma86 commented Dec 17, 2019

Uh oh!

fluttergithubbot commented Dec 17, 2019

Uh oh!

jmagman Dec 30, 2019

Uh oh!

franciscojma86 Jan 2, 2020

Uh oh!

jmagman Jan 2, 2020 •

edited

Loading

Uh oh!

jmagman Jan 7, 2020

Uh oh!

codecov bot commented Jan 7, 2020 •

edited

Loading

Uh oh!

googlebot commented Jan 7, 2020

Uh oh!

googlebot commented Jan 7, 2020

Uh oh!

googlebot commented Jan 7, 2020

Uh oh!

jmagman commented Jan 8, 2020

Uh oh!

franciscojma86 commented Jan 21, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

WIP Create .flutter-plugins file per platform #47258

WIP Create .flutter-plugins file per platform #47258

Uh oh!

Conversation

franciscojma86 commented Dec 17, 2019

Description

Related Issues

Tests

Checklist

Breaking Change

Uh oh!

fluttergithubbot commented Dec 17, 2019

Uh oh!

jmagman Dec 30, 2019

Choose a reason for hiding this comment

Uh oh!

franciscojma86 Jan 2, 2020

Choose a reason for hiding this comment

Uh oh!

jmagman Jan 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jmagman Jan 7, 2020

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Jan 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

googlebot commented Jan 7, 2020

Uh oh!

googlebot commented Jan 7, 2020

Uh oh!

googlebot commented Jan 7, 2020

Uh oh!

jmagman commented Jan 8, 2020

Uh oh!

franciscojma86 commented Jan 21, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jmagman Jan 2, 2020 •

edited

Loading

codecov bot commented Jan 7, 2020 •

edited

Loading