Repository navigation
Add a wrapper for accessing the URL launcher service. - #4688
Conversation
There was a problem hiding this comment.
There's a bit more ceremony required here. See the other wrappers for the pattern.
|
I see, I didn't pull in the changes made recently and was basing this off of an older pattern a8f6f44#diff-7d620ba5e4aa11648c48a973a928da2fR33 |
There was a problem hiding this comment.
I think we're going to want to use the term URL instead of URI. Ask @Hixie about that.
|
Android will parse the string as conforming to RFC 2396 while iOS expects the string to conform to RFC 1738. I believe 2396 updates 1738 and RFC 3986 updates or obsoletes both. So depending on the platform, there will be subtle changes in the conformance requirements of the string. That is why the mojom specifies that the platform will parse this instead of us. I associate URL with 1738 and URI with the others. |
|
The URL standard obsoletes RFC 3986, RFC 2396, and RFC 1738. |
chinmaygarde
changed the title
|
Done. Another look? |
|
|
|
Done. Rebased. |
cc @HansMuller
https://gist.github.com/chinmaygarde/99b3c6bc700a973a51639526d835319f if anyone needs the snippet.