Skip to content

Fix docker tag during upload as well #46252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tvolkert merged 1 commit into from
Dec 9, 2019
Merged

Fix docker tag during upload as well #46252

tvolkert merged 1 commit into from
Dec 9, 2019

Conversation

@tvolkert
Copy link
Contributor

@tvolkert tvolkert commented Dec 6, 2019

Description

In #46035, we fixed the docker
tag to be a legal tag during build. This PR makes the corresponding
change to the tag during upload. Without this, we build the right tag,
but then we try to upload the wrong tag.

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

@tvolkert
Fix docker tag during upload as well
6d0dc93 
In #46035, we fixed the docker
tag to be a legal tag during build.  This PR makes the corresponding
change to the tag during upload.  Without this, we build the right tag,
but then we try to upload the wrong tag.
@fluttergithubbot fluttergithubbot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Dec 6, 2019
@tvolkert tvolkert requested a review from gspencergoog December 6, 2019 22:21
gspencergoog
gspencergoog approved these changes Dec 6, 2019
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@tvolkert tvolkert merged commit 55f0bdc into flutter:master Dec 9, 2019
@tvolkert tvolkert deleted the docker branch December 9, 2019 20:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tvolkert @gspencergoog @googlebot @fluttergithubbot