Add bitcode and architectures to App.framework build ios framework command #46130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
c: contributor-productivity
jmagman
added
the
a: existing-apps
xster
reviewed
Dec 5, 2019
xster
reviewed
Dec 5, 2019
xster
reviewed
Dec 5, 2019
| } | ||
|
|
||
| Future<String> iPhoneSdkLocation() async { | ||
| Future<String> sdkLocation(SdkType sdk) async { |
Member
There was a problem hiding this comment.
If you add new public API surface, these need tests. (Feel free to do them in a separate PR)
Member
Author
There was a problem hiding this comment.
iPhoneSdkLocation didn't have any tests to update. Will add some.
xster
reviewed
Dec 5, 2019
packages/flutter_tools/lib/src/commands/build_ios_framework.dart
Outdated
Show resolved
Hide resolved
xster
reviewed
Dec 5, 2019
Member
|
LGTM |
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
xster
approved these changes
Dec 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make a fat universal binary for the Debug App.framework.
Enable bitcode for all versions of App.framework.
Related Issues
Fixes #46125
Fixes #46129
Tests
xcode_test
Update build_ios_framework_module_test.dart to check Debug App.framework architectures.
Checklist
///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read [Handling breaking changes].