Skip to content

Conversation

@zanderso
Copy link
Member

@zanderso zanderso commented Dec 4, 2019

Description

Previous PR removed too much info.

Issues

#46004

Tests

I added the following tests:

Updated test in upgrade_test.dart.

Breaking Change

Did any tests fail when you ran them? Please read [Handling breaking changes].

  • No, no existing tests failed, so this is not a breaking change.

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Dec 4, 2019
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvolkert tvolkert merged commit e98acc7 into flutter:master Dec 5, 2019
@zanderso zanderso deleted the no-op-upgrade-print branch December 5, 2019 20:22
@timsneath
Copy link
Contributor

@tvolkert is this a cherry-pick candidate?

@tvolkert
Copy link
Contributor

tvolkert commented Dec 5, 2019

Yep

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants