Name the docker_builder shard #46103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
|
Yeah, that's the defat name. 🤷♂️ You can add |
Contributor
Author
|
Is this patch correct, then? |
Contributor
|
Correct, you can even make it like "Docker Build" |
christopherfujino
changed the title
Contributor
Author
|
@fkorotkov it looks like the |
Contributor
Contributor
Author
|
Regardless of if it's failing, I'd like it to be named something obvious. "main" was confusing and had me looking in the Cirrus config file for a task named "main" |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
docker_buildershard on Cirrus has no name, so it show up as "main"