Skip to content

Re-enable hostonly tests on non-master branches #46037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tvolkert merged 2 commits into from
Dec 4, 2019
Merged

Re-enable hostonly tests on non-master branches #46037

tvolkert merged 2 commits into from
Dec 4, 2019

Conversation

@tvolkert
Copy link
Contributor

@tvolkert tvolkert commented Dec 3, 2019 •
edited
Loading

Description

This is a follow-on to #45455 - the test failures indicated a real problem, so re-enabling the tests on non-master.

Related Issues

#45453

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

@tvolkert
Disable tests that fail on non-master branches (part 2)
9efd507 
This is a follow-on to #45455
to get tests properly disabled on Cirrus when run on non-master
branches for non-PRs.

#45453
@tvolkert
Copy link
Contributor Author

tvolkert commented Dec 3, 2019

@Hixie @fkorotkov

@fkorotkov
Copy link
Contributor

fkorotkov commented Dec 4, 2019

LGTM

BTW I remember seen branches like revert-some-change. Seems checks will be ignored for such reverts with that logic. But if you create a PR from such branches then it should be fine.

@tvolkert
Copy link
Contributor Author

tvolkert commented Dec 4, 2019

Yup, we create PRs from such branches.

@tvolkert
Copy link
Contributor Author

tvolkert commented Dec 4, 2019

Per the discussion in #45453, the failing tests indicated a real problem on non-master, so I'm gonna close this and revert #45455

@tvolkert tvolkert closed this Dec 4, 2019
@tvolkert tvolkert deleted the cirrus branch December 4, 2019 00:15
@tvolkert tvolkert restored the cirrus branch December 4, 2019 00:18
@tvolkert tvolkert reopened this Dec 4, 2019
@tvolkert
Copy link
Contributor Author

tvolkert commented Dec 4, 2019

Argh, the revert contained some code that should still be around, so manually reverting the right stuff here instead.

@tvolkert tvolkert changed the title Disable tests that fail on non-master branches (part 2) Re-enable hostonly tests on non-master branches Dec 4, 2019
@tvolkert tvolkert merged commit 4c95bbd into flutter:master Dec 4, 2019
@tvolkert tvolkert deleted the cirrus branch December 4, 2019 03:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@xster xster xster approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tvolkert @fkorotkov @xster @googlebot