Skip to content

Ensure that docker tag is legal #46035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tvolkert merged 1 commit into from
Dec 4, 2019
Merged

Ensure that docker tag is legal #46035

tvolkert merged 1 commit into from
Dec 4, 2019

Conversation

@tvolkert
Copy link
Contributor

@tvolkert tvolkert commented Dec 3, 2019

Description

Our docker image build is failing with hotfix releases because the tag name is illegal
(cannot contain +). This fixes the tag name to be valid before attempting to build
the image.

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

@fluttergithubbot fluttergithubbot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Dec 3, 2019
@tvolkert tvolkert requested a review from gspencergoog December 3, 2019 23:50
@tvolkert tvolkert merged commit 066a992 into flutter:master Dec 4, 2019
@tvolkert tvolkert deleted the docker branch December 4, 2019 03:53
@tvolkert tvolkert mentioned this pull request Dec 6, 2019
Merged
8 tasks
tvolkert added a commit that referenced this pull request Dec 9, 2019
@tvolkert
Fix docker tag during upload as well (#46252)
55f0bdc 
In #46035, we fixed the docker
tag to be a legal tag during build.  This PR makes the corresponding
change to the tag during upload.  Without this, we build the right tag,
but then we try to upload the wrong tag.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tvolkert @gspencergoog @googlebot @fluttergithubbot